From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C36430EF75; Wed, 26 Nov 2025 16:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764176122; cv=none; b=naJmi694Mu+c6nmyFej+AMtHOGAjN8oFFnNa6OCPlED2TUJ/TQC58cY8DcI9X32i+XKxrz0fiOcNaKvzj9l/TSM3fJwggLtJr2APpNvjwG24Jqa0lf2F5JC8/35LO7JLA595O0JMiX+qXW51r9Qz5abhb8qxvq2S4euw+Q9NSoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764176122; c=relaxed/simple; bh=t6dQaMcFstDQXYR4H7vfqmgdXjeJ9mqjp2aG+oOBJVA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YkvN1ni9NfOSBkq+Ss6Ya2Q1gsjdEyxjR1P0+V9RIH4AKtmLMiCld6XOhi1jS5dTVsTLJVuu61texlmiN4Ijd7N+6jfvhC1+kuST9UrDByAK+trllKXfxh39HGhWJeeGSaAc8AJeQig8q0RXO4s2f7dsvA+np0ms3EjNBlt/TvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S090ngv+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S090ngv+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BB98C4CEF7; Wed, 26 Nov 2025 16:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764176121; bh=t6dQaMcFstDQXYR4H7vfqmgdXjeJ9mqjp2aG+oOBJVA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=S090ngv+Xbhos+RtW6FAhhF2zD8GG1Mg9v5UzfySDdEoipkzc+1XqAcSh2YoYJfAW iS0srhh3ZlxBSHoV8+ybImfU6P/zpjOAes/KkpyMPCjlxRvSjYpNHtdCrIsoNxSDNI 216nzH29D9Q6fOPPOM8x1pE6w5V1+ogJnMEjBHz4o5hcFRk5nyLzV1JtHWRqbaW7GE Q1PHawcGquKBStZ9XfMfSKLmlXjOfclrwofD5mubdgm5CmBsCQQsJZ9sZbli4jJyg4 LkAUiOSYjYqT00U5z0Y65WO9lZTbtGo4IHllfsTLwzHstwHZzOV/ayqc3gWxzNSyDC Gy3JUAT3XAhOQ== Message-ID: <795a8f3c-eff7-46d9-9175-a4ebe3f9ffd8@kernel.org> Date: Wed, 26 Nov 2025 17:55:14 +0100 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH] selftests: mptcp: initialize raw_addr to Null Content-Language: en-GB, fr-BE To: Ankit Khushwaha Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Shuah Khan , Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt References: <20251126163046.58615-1-ankitkhushwaha.linux@gmail.com> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <20251126163046.58615-1-ankitkhushwaha.linux@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Ankit, On 26/11/2025 17:30, Ankit Khushwaha wrote: > The "void *raw_addr" is left uninitialized when else path is > followed raising below warning. > > mptcp_connect.c:1262:11: warning: variable 'raw_addr' is used > uninitialized whenever 'if' condition is false > [-Wsometimes-uninitialized] > > so the fix is to assign *raw_addr to NULL to suppress the warning. Thank you for having shared this patch! > Signed-off-by: Ankit Khushwaha > --- > compiler used: clang version 21.1.5 (Fedora 21.1.5-1.fc43). > compilation cmd used: > make -C tools/testing/selftests/net/mptcp CC=clang V=1 -j8 > > this maybe also be false positive. But somehow clang - 21.1.5 > triggering this. I confirm this, I can reproduce the warning with Clang 21. It is indeed a false positive, because the code does that: if (addr.ss_family == AF_INET) raw_addr = &(((struct sockaddr_in *)&addr)->sin_addr); else if (addr.ss_family == AF_INET6) raw_addr = &(((struct sockaddr_in6 *)&addr)->sin6_addr); else xerror("bad family"); "xerror()" calls "exit(1)", so "raw_addr" is never used uninitialized. I'm not sure why Clang 21 reports that now, and not before, but well, the modification you did in the selftests doesn't hurt: Reviewed-by: Matthieu Baerts (NGI0) @Net maintainers: this patch can be applied in 'net' directly. @Antik: next time, please specify the target (net/net-next) in the subject, see [1]. No need to send a new version (except if the Net maintainers prefer), this patch can be applied on top of "net" without conflicts. [1] https://docs.kernel.org/process/maintainer-netdev.html Cheers, Matt -- Sponsored by the NGI0 Core fund.