Re: [PATCH net-next v2] tools: ynl-gen: use big-endian netlink attribute types

[Matthieu Baerts <matttbe@kernel.org>]

Hi Davide,

On 17/10/2024 11:47, Asbjørn Sloth Tønnesen wrote:
> Change ynl-gen-c.py to use NLA_BE16 and NLA_BE32 types to represent
> big-endian u16 and u32 ynl types.
> 
> Doing this enables those attributes to have range checks applied, as
> the validator will then convert to host endianness prior to validation.
> 
> The autogenerated kernel/uapi code have been regenerated by running:
>   ./tools/net/ynl/ynl-regen.sh -f
> 
> This changes the policy types of the following attributes:
> 
>   FOU_ATTR_PORT (NLA_U16 -> NLA_BE16)
>   FOU_ATTR_PEER_PORT (NLA_U16 -> NLA_BE16)
>     These two are used with nla_get_be16/nla_put_be16().
> 
>   MPTCP_PM_ADDR_ATTR_ADDR4 (NLA_U32 -> NLA_BE32)
>     This one is used with nla_get_in_addr/nla_put_in_addr(),
>     which uses nla_get_be32/nla_put_be32().

This modification looks good to me, but just in case, do you mind having
a quick look, and eventually send your Acked-by, please? :)

(...)

> diff --git a/net/mptcp/mptcp_pm_gen.c b/net/mptcp/mptcp_pm_gen.c
> index c30a2a90a192..5a6b2b4510d3 100644
> --- a/net/mptcp/mptcp_pm_gen.c
> +++ b/net/mptcp/mptcp_pm_gen.c
> @@ -14,7 +14,7 @@
>  const struct nla_policy mptcp_pm_address_nl_policy[MPTCP_PM_ADDR_ATTR_IF_IDX + 1] = {
>  	[MPTCP_PM_ADDR_ATTR_FAMILY] = { .type = NLA_U16, },
>  	[MPTCP_PM_ADDR_ATTR_ID] = { .type = NLA_U8, },
> -	[MPTCP_PM_ADDR_ATTR_ADDR4] = { .type = NLA_U32, },
> +	[MPTCP_PM_ADDR_ATTR_ADDR4] = { .type = NLA_BE32, },
>  	[MPTCP_PM_ADDR_ATTR_ADDR6] = NLA_POLICY_EXACT_LEN(16),
>  	[MPTCP_PM_ADDR_ATTR_PORT] = { .type = NLA_U16, },
>  	[MPTCP_PM_ADDR_ATTR_FLAGS] = { .type = NLA_U32, },

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.