Re: [PATCH mptcp-net] selftests: mptcp: fix MP_FAIL test-case

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Fri, 29 Apr 2022, Paolo Abeni wrote:

> The mentioned tests sometimes fails because the data
> transfer completes before any packet is sent on the 2nd
> link (the failing one).
>
> Address the issue reducing the "virtual" b/w available
> on the primary link.
>
> Fixes: bfd4cdbe7032 ("selftests: mptcp: add MP_FAIL reset testcase")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> together with the previous patch this fixes issues/265 for
> good here. I'm not adding the Close tag due to the mentioned
> dep, which may take a different/longer route
> ---
> tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> index a98fee834950..0d65295c1b33 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> @@ -2734,7 +2734,7 @@ fail_tests()
>
> 	# multiple subflows
> 	if reset_with_fail "MP_FAIL MP_RST" 2; then
> -		tc -n $ns2 qdisc add dev ns2eth1 root netem rate 20mbit delay 1
> +		tc -n $ns2 qdisc add dev ns2eth1 root netem rate 10mbit delay 5

The "MP_FAIL MP_RST" test still fails within a couple of minutes on my 
desktop with this change. I changed 10mbit to 1mbit and so far it is still 
running. You ok with slowing it down even more?

> 		pm_nl_set_limits $ns1 0 1
> 		pm_nl_set_limits $ns2 0 1
> 		pm_nl_add_endpoint $ns2 10.0.2.2 dev ns2eth2 flags subflow
> -- 
> 2.35.1
>
>
>

--
Mat Martineau
Intel