From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next 0/8] some cleanups
Date: Wed, 21 Feb 2024 17:18:15 +0100 [thread overview]
Message-ID: <81a4345f-8a51-430f-b84f-e0cf7da1bdcf@kernel.org> (raw)
In-Reply-To: <cover.1708497039.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 21/02/2024 7:31 am, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> Depends on:
> - dump for userspace pm, v14
>
> Geliang Tang (8):
> mptcp: make pm_remove_addrs_and_subflows static
> mptcp: drop duplicate header inclusions
> mptcp: update set_flags interfaces
> mptcp: set error messages for set_flags
> mptcp: drop lookup_by_id in lookup_addr
> mptcp: add use_id parameter for addresses_equal
> mptcp: add check_id for lookup_anno_list_by_saddr
> selftests: mptcp: flush userspace addrs list
Thank you for this clean-up!
Patches 1-3, 5 look good to me. But I have some comments for the others.
I think patches 6-7 can be simplified by just using one new variable,
not sure about patch 8.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2024-02-21 16:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 6:31 [PATCH mptcp-next 0/8] some cleanups Geliang Tang
2024-02-21 6:31 ` [PATCH mptcp-next 1/8] mptcp: make pm_remove_addrs_and_subflows static Geliang Tang
2024-02-21 6:31 ` [PATCH mptcp-next 2/8] mptcp: drop duplicate header inclusions Geliang Tang
2024-02-21 6:31 ` [PATCH mptcp-next 3/8] mptcp: update set_flags interfaces Geliang Tang
2024-02-21 6:31 ` [PATCH mptcp-next 4/8] mptcp: set error messages for set_flags Geliang Tang
2024-02-21 16:18 ` Matthieu Baerts
2024-02-21 6:31 ` [PATCH mptcp-next 5/8] mptcp: drop lookup_by_id in lookup_addr Geliang Tang
2024-02-21 6:31 ` [PATCH mptcp-next 6/8] mptcp: add use_id parameter for addresses_equal Geliang Tang
2024-02-21 16:19 ` Matthieu Baerts
2024-02-21 6:31 ` [PATCH mptcp-next 7/8] mptcp: add check_id for lookup_anno_list_by_saddr Geliang Tang
2024-02-21 16:20 ` Matthieu Baerts
2024-02-21 6:31 ` [PATCH mptcp-next 8/8] selftests: mptcp: flush userspace addrs list Geliang Tang
2024-02-21 15:47 ` selftests: mptcp: flush userspace addrs list: Tests Results MPTCP CI
2024-02-21 16:21 ` [PATCH mptcp-next 8/8] selftests: mptcp: flush userspace addrs list Matthieu Baerts
2024-02-21 16:18 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81a4345f-8a51-430f-b84f-e0cf7da1bdcf@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox