Re: [PATCH mptcp-next v12 10/15] selftests: mptcp: dump userspace addrs list

[Matthieu Baerts <matttbe@kernel.org>]

Hi Mat, Geliang,

On 15/02/2024 23:57, Mat Martineau wrote:
> On Wed, 14 Feb 2024, Geliang Tang wrote:
> 
>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>
>> This patch adds two new tests for userspace pm dump address and subflow.
>> Use userspace_pm_add_addr() and userspace_pm_add_sf() to add an address
>> and a suflow.
>>
> 
> Hi Geliang -
> 
> The kernel code looks good to me, but I realized the selftests need some
> changes.
> 
> In order to run the new tests with old kernels (without userspace dump
> address support), mptcp_lib_kallsyms_has checks are needed so the new
> functionality is skipped on old kernels (right Matthieu?).

Good point!

I didn't check what can be done, but yes, something needs to be done:
looking for a counter, a symbol, the output of a command, etc.

> Also, since our tests already take a long time to run, could the
> userspace dump addrs checks be integrated with an existing test like
> "userspace pm add & remove address"?

Good idea! (maybe even more tests doing the same actions, but checking
different things, could be merged with a new title)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.