Re: [PATCH mptcp-next v5 00/11] refactor push pending

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Thu, 6 Oct 2022, Geliang Tang wrote:

> v5:
> - address Mat's comments in v4.

Hi Geliang -

Thanks for the v5. I haven't finished looking over all the patches in 
detail yet, but two things I do want to reply to right now:

  * Thanks for explaining in patch 4 that last_snd is still useful for 
round robin. I had forgotten about that, and it looked like a "write-only" 
variable in the kernel code.

  * In the meeting today Paolo suggested that a good test for the new 
scheduler loop would be to modify simult_flows.sh to use much larger 
files, then see if the modified code slowed down any of the simult_flows 
tests.

He suggested making the test file 10x larger in simult_flows.sh:

-	size=$((2 * 2048 * 4096))
+	size=$((2 * 2048 * 4096 * 10))

Can you compare the test times between the export branch and this series, 
with both of them using the larger file size?


Thanks,

Mat


>
> v4:
> - update __mptcp_subflow_push_pending as Mat suggested.
> - add more patches from "BPF redundant scheduler" series.
>
> v3:
> - add a cleanup patch.
> - remove msk->last_snd in mptcp_subflow_get_send().
> - add the loop that calls the scheduler again in __mptcp_push_pending().
>
> v2:
> - add snd_burst check in dfrags loop as Mat suggested.
>
> Refactor __mptcp_push_pending() and __mptcp_subflow_push_pending() to
> remove duplicate code and support redundant scheduler more easily in
> __mptcp_subflow_push_pending().
>
> Geliang Tang (11):
>  Squash to "mptcp: add get_subflow wrappers"
>  mptcp: 'first' argument for subflow_push_pending
>  mptcp: refactor push_pending logic
>  mptcp: drop last_snd for burst scheduler
>  mptcp: simplify push_pending
>  mptcp: multi subflows push_pending
>  mptcp: use msk instead of mptcp_sk
>  mptcp: refactor subflow_push_pending logic
>  mptcp: simplify subflow_push_pending
>  mptcp: multi subflows subflow_push_pending
>  mptcp: multi subflows retrans support
>
> net/mptcp/pm.c         |   9 +-
> net/mptcp/pm_netlink.c |   3 -
> net/mptcp/protocol.c   | 285 ++++++++++++++++++++++-------------------
> net/mptcp/protocol.h   |   5 +-
> net/mptcp/sched.c      |  61 +++++----
> 5 files changed, 184 insertions(+), 179 deletions(-)
>
> -- 
> 2.35.3
>
>
>

--
Mat Martineau
Intel