Re: [PATCH bpf-next 0/4] selftests/bpf: new MPTCP subflow subtest & improvements

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

(only with MPTCP ML in cc)

On 07/05/2024 12:53, Matthieu Baerts (NGI0) wrote:
> In this series from Geliang, modifying MPTCP BPF selftests, we have:
> 
> - SIGINT support
> 
> - A new macro to reduce duplicated code
> 
> - A new MPTCP subflow BPF program setting socket options per subflow: it
>   looks better to have this old test program in the BPF selftests to
>   track regressions and to serve as example.
> 
>   Note: Nicolas is no longer working for Tessares, but he did this work
>   while working for them, and his email address is no longer available.
> 
> - A new MPTCP BPF subtest validating the new BPF program.
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Geliang Tang (3):
>       selftests/bpf: Handle SIGINT when creating netns

Regarding this patch, do you mind looking for a new version that is
generic as requested by Alexei, please?

I guess he meant adding a new helper in network_helpers.c doing "ip
netns add" + "signal(SIGINT)" + "open_netns()", and using it everywhere
"ip netns add" + "open_netns()" are used. (I guess you will need another
helper to "close_netns()" + "ip netns del" + remove the signal handler
or the netns name.)
Be careful that sometimes, more than one netns is used.

>       selftests/bpf: Add RUN_MPTCP_TEST macro
>       selftests/bpf: Add mptcp subflow subtest
> 
> Nicolas Rybowski (1):
>       selftests/bpf: Add mptcp subflow example

For your information, I modified our tree to apply comments from Alexei:

New patches for t/upstream:
- 12609b68c8d9: tg:msg: clarify the commit message
- a4ad7c6dee6a: Revert "selftests/bpf: Add RUN_MPTCP_TEST macro"
- f457d8911a38: conflict in t/selftests-bpf-Add-mptcp-subflow-subtest
- 5072ff915f8d: Revert "selftests/bpf: Handle SIGINT when creating netns"
- 9df135860724: conflict in t/selftests-bpf-Add-bpf-scheduler-test
- 8ef1339edc8a: conflict in t/selftests-bpf-add-bpf_first-scheduler
- 2f5ced304cc1: conflict in t/selftests-bpf-Add-bpf_bkup-scheduler
- e9bafe786620: conflict in t/selftests-bpf-Add-bpf_rr-scheduler
- dca93e3c7e9a: conflict in t/selftests-bpf-Add-bpf_red-scheduler
- 5349d85a8c73: conflict in t/selftests-bpf-Add-bpf_burst-scheduler
- Results: 304693999ba6..b74adae98e0d (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/715c505a46ae8394e40fdeb54e0ecea27f95dc5d/checks

I will also modify the tree not to remove MPTCP_SCHED_TEST() macro as
asked by Alexei.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.