MPTCP Linux Development
 help / color / mirror / Atom feed
From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Geliang Tang <geliang.tang@suse.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next] selftests: mptcp: update pm_nl_ctl usage header
Date: Fri, 10 Jun 2022 17:09:31 -0700 (PDT)	[thread overview]
Message-ID: <8a34aa1e-9ef5-666a-2452-786157253c@linux.intel.com> (raw)
In-Reply-To: <4894e178ac9a9ee233246a73e5c968858b7a3a87.1654839889.git.geliang.tang@suse.com>

On Fri, 10 Jun 2022, Geliang Tang wrote:

> The usage header of pm_nl_ctl command doesn't match with the context. So
> this patch adds the missing userspace PM keywords 'ann', 'rem', 'csf',
> 'dsf', 'events' and 'listen' in it.
>
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>

Appreciate the fix to the help text.

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>


> ---
> tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c
> index 6a2f4b981e1d..4dd87bb9ee91 100644
> --- a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c
> +++ b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c
> @@ -31,7 +31,7 @@
>
> static void syntax(char *argv[])
> {
> -	fprintf(stderr, "%s add|get|set|del|flush|dump|accept [<args>]\n", argv[0]);
> +	fprintf(stderr, "%s add|ann|rem|csf|dsf|get|set|del|flush|dump|events|listen|accept [<args>]\n", argv[0]);
> 	fprintf(stderr, "\tadd [flags signal|subflow|backup|fullmesh] [id <nr>] [dev <name>] <ip>\n");
> 	fprintf(stderr, "\tann <local-ip> id <local-id> token <token> [port <local-port>] [dev <name>]\n");
> 	fprintf(stderr, "\trem id <local-id> token <token>\n");
> -- 
> 2.35.3
>
>
>

--
Mat Martineau
Intel

      parent reply	other threads:[~2022-06-11  0:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10  5:45 [PATCH mptcp-next] selftests: mptcp: update pm_nl_ctl usage header Geliang Tang
2022-06-10  7:11 ` selftests: mptcp: update pm_nl_ctl usage header: Tests Results MPTCP CI
2022-06-11  0:09 ` Mat Martineau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a34aa1e-9ef5-666a-2452-786157253c@linux.intel.com \
    --to=mathew.j.martineau@linux.intel.com \
    --cc=geliang.tang@suse.com \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox