From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang.tang@suse.com>, Paolo Abeni <pabeni@redhat.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v16 0/8] userspace pm remove id 0 subflow & address
Date: Fri, 13 Oct 2023 10:31:52 +0200 [thread overview]
Message-ID: <8b9e4a05-7b65-4b2a-b4d9-3c5b03a894f9@kernel.org> (raw)
In-Reply-To: <cover.1697175899.git.geliang.tang@suse.com>
Hi Geliang, Paolo,
On 13/10/2023 07:46, Geliang Tang wrote:
> v16:
> - address Matt's comments in v15.
Thank you for the new version! It looks good to me!
Reviewed-by: Matthieu Baerts <matttbe@kernel.org>
I plan to apply 'mptcp: userspace pm send RM_ADDR for ID 0' to the
"-net" part of the tree. I'm not sure about "mptcp: add
__mptcp_subflow_disconnect helper".
@Paolo: are you still OK with "mptcp: add __mptcp_subflow_disconnect
helper" commit?
Do you think we should send that to "-net"? The patch looks OK to me but
on the other hand, it is not a big issue to reset the initial subflow
(but not ideal). WDYT?
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next prev parent reply other threads:[~2023-10-13 8:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 5:46 [PATCH mptcp-next v16 0/8] userspace pm remove id 0 subflow & address Geliang Tang
2023-10-13 5:46 ` [PATCH mptcp-next v16 1/8] mptcp: add __mptcp_subflow_disconnect helper Geliang Tang
2023-10-13 5:46 ` [PATCH mptcp-next v16 2/8] selftests: mptcp: join: no RST when rm subflow/addr Geliang Tang
2023-10-13 5:46 ` [PATCH mptcp-next v16 3/8] Squash to "mptcp: add mptcpi_subflows_total counter" Geliang Tang
2023-10-13 10:32 ` Paolo Abeni
2023-10-13 10:46 ` Matthieu Baerts
2023-10-13 15:35 ` Paolo Abeni
2023-10-16 11:53 ` Matthieu Baerts
2023-10-16 13:50 ` Paolo Abeni
2023-10-16 20:26 ` Matthieu Baerts
2023-10-13 5:46 ` [PATCH mptcp-next v16 4/8] Squash to "selftests: mptcp: add chk_subflows_total helper" Geliang Tang
2023-10-13 5:46 ` [PATCH mptcp-next v16 5/8] selftests: mptcp: userspace pm remove initial subflow Geliang Tang
2023-10-13 5:46 ` [PATCH mptcp-next v16 6/8] mptcp: userspace pm send RM_ADDR for ID 0 Geliang Tang
2023-10-13 5:46 ` [PATCH mptcp-next v16 7/8] mptcp: userspace pm rename remove_err to out Geliang Tang
2023-10-13 5:46 ` [PATCH mptcp-next v16 8/8] selftests: mptcp: userspace pm send RM_ADDR for ID 0 Geliang Tang
2023-10-13 6:57 ` selftests: mptcp: userspace pm send RM_ADDR for ID 0: Tests Results MPTCP CI
2023-10-13 10:18 ` MPTCP CI
2023-10-13 8:31 ` Matthieu Baerts [this message]
2023-10-13 9:36 ` [PATCH mptcp-next v16 0/8] userspace pm remove id 0 subflow & address Matthieu Baerts
2023-10-13 11:30 ` Geliang Tang
2023-10-13 11:54 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b9e4a05-7b65-4b2a-b4d9-3c5b03a894f9@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang.tang@suse.com \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox