MPTCP Linux Development
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Hangbin Liu <hangbin.liu@linux.dev>, MPTCP Linux <mptcp@lists.linux.dev>
Cc: Hangbin Liu <liuhangbin@kylinos.cn>
Subject: Re: [PATCH mptcp-next v4 0/2] selftests: mptcp: convert iptables to nftables
Date: Wed, 9 Sep 2026 13:24:08 +0200	[thread overview]
Message-ID: <8bda50ef-a62b-4ad4-81c8-ca95d92da57f@kernel.org> (raw)
In-Reply-To: <20260908-mptcp_nft-v4-0-af0a6120240b@kylinos.cn>

Hi Hangbin,

On 08/09/2026 13:36, Hangbin Liu wrote:
> iptables has been deprecated for years. The Linux kernel has included
> nftables as the successor to iptables since 2014, and every major
> distribution uses nftables as the default packet filtering framework.
> The iptables command we run on modern systems is actually iptables‑nft,
> a compatibility layer that translates iptables syntax to nftables rules
> behind the scenes.
> 
> There are also some features that can be set easily with nft, while we need
> to convert to BPF code under iptables, such as MPTCP add‑addr and
> remove‑addr suboptions. To make future work easier, convert iptables usage
> in mptcp to nftables.
Thank you for the new version. It looks good to me:

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Now in our tree (I just fixed the indentation after 'if .* nft' lines
not to align the rest of the nft commands with the conditional code):

New patches for t/upstream:
- 23ac116ea2c4: selftests: mptcp: convert iptables to nftables for
mptcp_sockopt.sh
- 0ae33af3f73f: selftests: mptcp: convert iptables to nftables for
mptcp_join.sh
- Results: ca7966735328..2dc29b34b99a (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/b49aa4201a14e200297db9adcde3495e5a778517/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


      parent reply	other threads:[~2026-09-09 11:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 11:36 [PATCH mptcp-next v4 0/2] selftests: mptcp: convert iptables to nftables Hangbin Liu
2026-09-08 11:36 ` [PATCH mptcp-next v4 1/2] selftests: mptcp: convert iptables to nftables for mptcp_sockopt.sh Hangbin Liu
2026-09-08 11:36 ` [PATCH mptcp-next v4 2/2] selftests: mptcp: convert iptables to nftables for mptcp_join.sh Hangbin Liu
2026-09-08 13:01 ` [PATCH mptcp-next v4 0/2] selftests: mptcp: convert iptables to nftables MPTCP CI
2026-09-09 11:24 ` Matthieu Baerts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bda50ef-a62b-4ad4-81c8-ca95d92da57f@kernel.org \
    --to=matttbe@kernel.org \
    --cc=hangbin.liu@linux.dev \
    --cc=liuhangbin@kylinos.cn \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox