From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v2 5/7] selftests: mptcp: drop iptables/ip6tables vars
Date: Fri, 16 Feb 2024 14:45:22 +0100 [thread overview]
Message-ID: <914511c5-ace0-4ff9-9695-c5f7ffef1c03@kernel.org> (raw)
In-Reply-To: <fdcfea6deedc64317296cd063c037b45d495c6b7.1708076886.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 16/02/2024 10:50, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> Since iptables-legacy/ip6tables-legacy are dropped in the commit
> 5b31f0f6f954 ("selftests: mptcp: stop forcing iptables-legacy"),
> there's no need to use ${iptables}/${ip6tables} variables anymore.
I agree, there is no need to use variables for the moment. But as I
mentioned in the commit message, I kept "the variables to easily change
them later or add options". They don't hurt, we might want to use
'iptables -w', force using 'iptables-nft' if available, or other options
for the debugging. I don't think we need this not so small patch.
In other words, the patch is OK, but maybe we don't need it?
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-02-16 13:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 9:50 [PATCH mptcp-next v2 0/7] add helpers and vars in mptcp_lib.sh, part 1 Geliang Tang
2024-02-16 9:50 ` [PATCH mptcp-next v2 1/7] selftests: mptcp: netlink: drop duplicate var ret Geliang Tang
2024-02-16 9:50 ` [PATCH mptcp-next v2 2/7] selftests: mptcp: simult flows: define missing vars Geliang Tang
2024-02-16 9:50 ` [PATCH mptcp-next v2 3/7] selftests: mptcp: join: change capture/checksum as bool Geliang Tang
2024-02-16 9:50 ` [PATCH mptcp-next v2 4/7] selftests: mptcp: diag: change timeout_poll to 30 Geliang Tang
2024-02-16 9:50 ` [PATCH mptcp-next v2 5/7] selftests: mptcp: drop iptables/ip6tables vars Geliang Tang
2024-02-16 13:45 ` Matthieu Baerts [this message]
2024-02-16 9:50 ` [PATCH mptcp-next v2 6/7] selftests: mptcp: add ss mptcp support checks Geliang Tang
2024-02-16 13:46 ` Matthieu Baerts
2024-02-16 9:50 ` [PATCH mptcp-next v2 7/7] selftests: mptcp: add mptcp_lib_check_tools helper Geliang Tang
2024-02-16 10:14 ` selftests: mptcp: add mptcp_lib_check_tools helper: Tests Results MPTCP CI
2024-02-16 10:24 ` Matthieu Baerts
2024-02-16 10:45 ` MPTCP CI
2024-02-16 11:08 ` MPTCP CI
2024-02-16 11:27 ` MPTCP CI
2024-02-16 13:48 ` [PATCH mptcp-next v2 7/7] selftests: mptcp: add mptcp_lib_check_tools helper Matthieu Baerts
2024-02-16 13:43 ` [PATCH mptcp-next v2 0/7] add helpers and vars in mptcp_lib.sh, part 1 Matthieu Baerts
2024-02-16 13:56 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=914511c5-ace0-4ff9-9695-c5f7ffef1c03@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox