From: Matthieu Baerts <matttbe@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-net] mptcp: really cope with fastopen race.
Date: Tue, 30 Jan 2024 13:08:15 +0100 [thread overview]
Message-ID: <91d6bd65-e102-427a-b02c-c221d453db84@kernel.org> (raw)
In-Reply-To: <02fe7afaec6fac65fc2da5922efe25d6ebdebc88.1706132185.git.pabeni@redhat.com>
Hi Paolo, Mat,
On 24/01/2024 22:36, Paolo Abeni wrote:
> Fastopen and PM-trigger subflow shutdown can race, as reported by
> syzkaller.
>
> In my first attempt to close such race, I missed the fact that
> the subflow status can change again before the subflow_state_change
> callback is invoked.
>
> Address the issue additionally copying with all the states directly
> reachable from TCP_FIN_WAIT1.
Thank you for the patch and the review!
Now in our tree (fix for -net) without the '.' at the end of the commit
title and a Closes tag ;)
New patches for t/upstream-net and t/upstream:
- d59403d0c91b: mptcp: really cope with fastopen race
- Results: ca82f8ccb3cc..6d56aa24e733 (export-net)
- Results: 4b8f1ec22243..cdd4fe00f4c5 (export)
Tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20240130T120521
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20240130T120521
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-01-30 12:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 21:36 [PATCH mptcp-net] mptcp: really cope with fastopen race Paolo Abeni
2024-01-24 22:43 ` mptcp: really cope with fastopen race.: Tests Results MPTCP CI
2024-01-24 22:43 ` MPTCP CI
2024-01-27 1:18 ` [PATCH mptcp-net] mptcp: really cope with fastopen race Mat Martineau
2024-01-29 9:35 ` Paolo Abeni
2024-01-29 19:16 ` Mat Martineau
2024-01-30 8:38 ` Paolo Abeni
2024-01-27 2:24 ` mptcp: really cope with fastopen race.: Tests Results MPTCP CI
2024-01-27 3:23 ` MPTCP CI
2024-01-30 12:08 ` Matthieu Baerts [this message]
2024-02-05 16:00 ` [PATCH mptcp-net] mptcp: really cope with fastopen race Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91d6bd65-e102-427a-b02c-c221d453db84@kernel.org \
--to=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox