Re: [PATCH mptcp-net 0/5] selftests: mptcp: unique subtest names

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 13/02/2024 05:21, Geliang Tang wrote:
> On Fri, Feb 09, 2024 at 06:28:38PM +0100, Matthieu Baerts (NGI0) wrote:
>> It is important to have a unique (sub)test name in TAP, because some CI
>> environments drop tests with duplicated name.
>>
>> When working on adding subtests support in Netdev's NIPA CI, I found out
>> some subtests had the same name. The name is used as a key, it should
>> then be unique, otherwise we don't track duplicated tests.
>>
>> The fixes have been split in different patches, because it fixes
>> different commits. But the idea is always the same: make sure subtest
>> names are unique.
>>
>> The last patch is not for -net, that's a new feature to make sure we
>> don't add duplicated names later.
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>> ---
>> Matthieu Baerts (NGI0) (5):
>>       selftests: mptcp: simult flows: fix some subtest names
>>       selftests: mptcp: userspace_pm: unique subtest names
>>       selftests: mptcp: diag: unique 'in use' subtest names
>>       selftests: mptcp: diag: unique 'cestab' subtest names
>>       selftests: mptcp: lib: catch duplicated subtest entries
> 
> Hi Matt,
> 
> I'd like to review this series this week.

Thank you!

> Please delegate them for
> me on Patchwork. I can't delegate them by myself.

Sorry, I'm still not able to do that, we need to wait for kernel.org IT
team to do the modification.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.