From: Paolo Abeni <pabeni@redhat.com>
To: Dmytro Shytyi <dmytro@shytyi.net>, mptcp@lists.linux.dev
Subject: Re: [RFC PATCH mptcp-next v12 7/7] selftests: mptfo initiator/listener
Date: Mon, 03 Oct 2022 10:31:02 +0200 [thread overview]
Message-ID: <965056bb46f0d3172d5436889b0849c5795caef6.camel@redhat.com> (raw)
In-Reply-To: <04007982-1066-5099-852e-580de8d3cf9c@shytyi.net>
On Sat, 2022-10-01 at 05:03 +0200, Dmytro Shytyi wrote:
> Thank you for this comment. I keep it in my notebook for the moment. I
> will come back to tests, when I will see the proper result of Initiator
> and Listener, if you don't mind?
Better self-tests will allow you to more easily validates your patches,
and a complete self-test is required for merging. I suggest to not
postpone this.
Thanks,
Paolo
p.s. to validate this code, thanks to Mat, there are a few packetdrill
available:
https://github.com/multipath-tcp/packetdrill/tree/mptcp-net-next/gtests/net/mptcp/fastopen
you just need to remote the '.TODO' suffix.
next prev parent reply other threads:[~2022-10-03 8:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 22:53 [RFC PATCH mptcp-next v12 0/7] mptcp: Fast Open Mechanism Dmytro Shytyi
2022-09-27 22:53 ` [RFC PATCH mptcp-next v12 1/7] mptcp: introduce MSG_FASTOPEN flag Dmytro Shytyi
2022-09-28 9:01 ` Paolo Abeni
2022-10-01 3:08 ` Dmytro Shytyi
2022-10-03 8:02 ` Paolo Abeni
2022-10-03 11:26 ` Paolo Abeni
2022-09-27 22:53 ` [RFC PATCH mptcp-next v12 2/7] mptcp: fix retrans., add mptfo vars to msk Dmytro Shytyi
2022-09-28 9:05 ` Paolo Abeni
2022-10-01 3:01 ` Dmytro Shytyi
2022-09-27 22:53 ` [RFC PATCH mptcp-next v12 3/7] mptcp: add subflow_v(4,6)_send_synack() Dmytro Shytyi
2022-09-28 9:23 ` Paolo Abeni
2022-10-01 2:59 ` Dmytro Shytyi
2022-09-27 22:53 ` [RFC PATCH mptcp-next v12 4/7] mptcp: sockopt: make 'tcp_fastopen_connect' generic Dmytro Shytyi
2022-09-28 9:26 ` Paolo Abeni
2022-10-01 2:50 ` Dmytro Shytyi
2022-09-27 22:53 ` [RFC PATCH mptcp-next v12 5/7] mptcp: add TCP_FASTOPEN_NO_COOKIE support Dmytro Shytyi
2022-09-27 22:53 ` [RFC PATCH mptcp-next v12 6/7] mptcp: add TCP_FASTOPEN option Dmytro Shytyi
2022-09-28 9:28 ` Paolo Abeni
2022-10-01 2:49 ` Dmytro Shytyi
2022-09-27 22:53 ` [RFC PATCH mptcp-next v12 7/7] selftests: mptfo initiator/listener Dmytro Shytyi
2022-09-27 23:23 ` selftests: mptfo initiator/listener: Build Failure MPTCP CI
2022-09-28 0:38 ` selftests: mptfo initiator/listener: Tests Results MPTCP CI
2022-09-28 9:45 ` [RFC PATCH mptcp-next v12 7/7] selftests: mptfo initiator/listener Paolo Abeni
2022-10-01 3:03 ` Dmytro Shytyi
2022-10-03 8:31 ` Paolo Abeni [this message]
2022-10-03 10:48 ` Dmytro Shytyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=965056bb46f0d3172d5436889b0849c5795caef6.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=dmytro@shytyi.net \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox