public inbox for mptcp@lists.linux.dev
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: "Geliang Tang" <geliang@kernel.org>,
	"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: MPTCP Upstream <mptcp@lists.linux.dev>, Gang Yan <yangang@kylinos.cn>
Subject: Re: [PATCH mptcp-next] selftests: mptcp: diag: sort all #include
Date: Fri, 30 Jan 2026 19:54:56 +0100	[thread overview]
Message-ID: <97558e02-8fac-4970-8597-bc4ffe4f178f@kernel.org> (raw)
In-Reply-To: <e13a0b73a01583e614e2b7e116075a24d9178472.camel@kernel.org>

Hi Geliang, Thomas,

On 30/01/2026 14:50, Geliang Tang wrote:
> On Fri, 2026-01-30 at 11:53 +0100, Thomas Weißschuh wrote:
>> On Fri, Jan 30, 2026 at 11:41:43AM +0100, Matthieu Baerts (NGI0)
>> wrote:
>>> This file is the only one from this directory not to have all these
>>> header inclusions sorted by type and alphabetical order.
>>>
>>> Adapt them, to ease the reading, prevent conflicts during potential
>>> future backport modifying these lines, and also to avoid having
>>> UAPI
>>> header inclusions before libc ones, see [1].
>>>
>>> Link:
>>> https://lore.kernel.org/20260120-uapi-sockaddr-v2-1-63c319111cf6@linutronix.de
>>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>>
>> Thanks!
>>
>> Reviewed-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> 
> Looks good to me too!
> 
>     Reviewed-by: Geliang Tang <geliang@kernel.org>

Thank you for the reviews!

Now in our tree:

New patches for t/upstream:
- 463bdbb2c21d: selftests: mptcp: diag: sort all #include
- Results: 847c469e539c..1f27d14ad280 (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/d713fc185b84b7e4f02beff96022692bce694318/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


  reply	other threads:[~2026-01-30 18:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-30 10:41 [PATCH mptcp-next] selftests: mptcp: diag: sort all #include Matthieu Baerts (NGI0)
2026-01-30 10:53 ` Thomas Weißschuh
2026-01-30 13:50   ` Geliang Tang
2026-01-30 18:54     ` Matthieu Baerts [this message]
2026-01-30 19:35 ` MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97558e02-8fac-4970-8597-bc4ffe4f178f@kernel.org \
    --to=matttbe@kernel.org \
    --cc=geliang@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=yangang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox