From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60EF284E18 for ; Wed, 8 May 2024 13:47:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715176029; cv=none; b=YXYH2lJF1ZIKQW23GUdAuMoNMlCRVbB3/N1GzSBmrEfMa3sOGSpsgg32EXZJDXZi2UyoLWsYljFPs2DoS93bU8rMTVISaPypA4LyMCGnsaQhgEacEYM5V8aX3BwEV7tYW7CcraWE+eAXDL+26IqVncLrqj+aFI/eHsy2KZdsF4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715176029; c=relaxed/simple; bh=u6EyzHXd27fFGrN9Et656hCo/08PPyT+hT+CjlkxkTU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=NV70mhIXCyW22KJElNbH5IgbCHRv60SvL/MtL3Re6xPAEXurCG2LPiHppZ7s8fujIbnTfeShzohL1SxvCuJE1f0VikBAB5xv3dlmxWvGiBvcHECM1tkSuk9QnMEHNUYDfosyUO5YhQPzO+QG5gsy4UqJGBlDzIfY1+YqlxNQ8/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=k1TN47+C; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="k1TN47+C" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2b2738ce656so3654203a91.0 for ; Wed, 08 May 2024 06:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715176025; x=1715780825; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=9Cy96MEbs4JLv+XlnJDrNT2CJ2qEQRDaH5Qu53Pf8ZU=; b=k1TN47+CWOS8ydAKrzn72KQqvnw2Fe6b/gVYwSH7iHJ66G5FezMDWU1b67kwePWpNQ Epo9SSe5IR8V9wOkuw2B4fhqm0mN4gJFO5l8SVQey1Y4gd/Yl+rWYO7ph9U/HY7Uz8mR EUDqDlQH5AWWB7uKaPVPQ0IWjgweVCJH1jvIVjDH1AyFSH1RDaWmedbKuADR90LZtIGG A+1/UZKuLRzp7oA1it89rLiS8cSaJiKXkYfbpcHnLMt3MXZmFodEKDf/pgaC55ALx3vK EdSw+JdBF7sb2BgZy06N74B3ayLT2F7E8DPylSoFh8SLRgaIRZYUmkPoAB6LnsQcj4j2 z1TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715176025; x=1715780825; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9Cy96MEbs4JLv+XlnJDrNT2CJ2qEQRDaH5Qu53Pf8ZU=; b=qn9ybeZpL+qRfseCwlz4uJP173djG0kzzxS4jtmp517xv9oGkYWlhbn7oek8JOW/0F aBTN9+uVqj8VqtlhSG7zK4eqy7Ga1lWbi/oDn7Ouqdol2RJvZMVfgv8F69629b0hlbyf 5qzIkzSc63Gwgt3vHWOGGV+Bq1s7TuZKyF3TV5K9kWVcmyChbNBcwcwZVskigXA+kFmP VjWh7ets/Zn5lSiOBtm9uK98PC4La/Zxtnt2JcrL+DFhh/MnmfXzMGzHKyawYzxmbtRp nIjA4dpWuIfINBgt2JzQMco+RoGmyCnjnnUa336s1955WRMjACrv5wm7gTYkliWuH4Kp JewA== X-Forwarded-Encrypted: i=1; AJvYcCVjeR5YPHVDcTj4Ip6vFrkTVI2N8f1ETP0/z/4FQiDjxC1fu+6CCrDTaf3LeMJ8oc98ERB/iqnxoACDUwhK+PwFBYsRyAA= X-Gm-Message-State: AOJu0YyPyeGDVMfKpmpgZxTXO44UtVpUGRnRNB4iGE774m1tGVxU8cFg qHOhwd5HrvY+mRkXWiTFPLSKyR23uGduPI4Jn6GYxqQJykbiuRh5diUucp/rf+vwFiPqdISnDyu m3w== X-Google-Smtp-Source: AGHT+IGkEzt3rrLCYEAc2MIkDJ4rSudkNPJV/ZI7YDr6FjDNwR59XbPWzyPuXmQfxq7n/1Jp45z9S3futCA= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90b:128d:b0:2b4:32ae:483e with SMTP id 98e67ed59e1d1-2b61638c780mr8658a91.2.1715176024465; Wed, 08 May 2024 06:47:04 -0700 (PDT) Date: Wed, 8 May 2024 06:47:03 -0700 In-Reply-To: <20240507214254.2787305-1-edliaw@google.com> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240507214254.2787305-1-edliaw@google.com> Message-ID: Subject: Re: [PATCH v2 0/5] Define _GNU_SOURCE for sources using From: Sean Christopherson To: Edward Liaw Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , "=?utf-8?B?QW5kcsOp?= Almeida" , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , "Andreas =?utf-8?Q?F=C3=A4rber?=" , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Tue, May 07, 2024, Edward Liaw wrote: > 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced > asprintf into kselftest_harness.h, which is a GNU extension and needs > _GNU_SOURCE to either be defined prior to including headers or with the > -D_GNU_SOURCE flag passed to the compiler. > > v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-edliaw@google.com/ > v2: add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single > location. Remove #define _GNU_SOURCE from source code to resolve > redefinition warnings. > > Edward Liaw (5): > selftests: Compile kselftest headers with -D_GNU_SOURCE > selftests/sgx: Include KHDR_INCLUDES in Makefile > selftests: Include KHDR_INCLUDES in Makefile > selftests: Drop define _GNU_SOURCE > selftests: Drop duplicate -D_GNU_SOURCE Can you rebase this on top of linux-next? I have a conflicting fix[*] for the KVM selftests queued for 6.10, and I would prefer not to drop that commit at this stage as it would require a rebase of a pile of other commits. And I doubt KVM is the only subsystem that has a targeted fix for the _GNU_SOURCE mess. If we want/need to get a fix into 6.9, then IMO we should just revert 809216233555 ("selftests/harness: remove use of LINE_MAX"), as that came in quite late in the 6.9 cycle, and I don't think it's feasible to be 100% confident that globally defining _GNU_SOURCE works for all selftests, i.e. we really should have a full cycle for folks to test. [*] https://github.com/kvm-x86/linux/commit/730cfa45b5f4