From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D8B484DED for ; Wed, 8 May 2024 13:54:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715176485; cv=none; b=M6rgSlYJfcYToO48kBw0tKH9QfWLM4O/Yc7nZ/+CAu6MHIdgclFSryX53Vyd5SFhxA5wCFiUG7bxkOhvAgMr3CAwOJRFiaoPafTmMaDsCsW04ao5/zJRJ9fG/aZIcmQE3ugldhvVTrdEZAdGTgtjevz+pfXDCTLBKW2gilKDDrY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715176485; c=relaxed/simple; bh=c4rrNnRvo0cBlTP42xOOVWUGWry3TUGUYL7wXej88eM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=G/j83NMMEw9nB2lSaS0wfEucalWwXFc6gq81Nhb6lOVDlwnulIpUGVeoqowkzL6kpVDBShseAOX4tH2hScWmkGInJ9MxeNtizQ91sEnXRSmV0VYbESo4k8tHlklvjtOuUpb1D+UeGn2PawGEFWEWTZJToLuw5j30IJVHkxPK6Xc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Nw61uR1t; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Nw61uR1t" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dc743cc50a6so5314116276.2 for ; Wed, 08 May 2024 06:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715176482; x=1715781282; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=qrxifLi18HwIXN/paZijnWPdESXfJJzxe/+u8UtVff4=; b=Nw61uR1tNwVxzCRFAgL9KqjamKibhhm5/G2K/nWymX+t6+Iqr+Y4h5iV9cq49fGmYf uVFEc6ygXvjKhi8737KELP0ARVaJ4DnccNaVEOtzXPI4ZgDQcXzmqqkw7tpGBZ+6QEHN 3XfDJyDP2HwJjxqsKubcYRNH6bbB882sS6t5P5Po8EVxbJIJsCjLEWJqInhkXGaIexu+ SEtzsGueACphyISptGqH9t2ulp6mnZqH0hnK0XhOqZpFRhqtZk0NbXBi17aS1k9v1JiZ poBjtGHrKYwdeNwlualA8udJMCTDyequyoLLnjS6sl91dfhpu09rdcYuHHG1Bns1+tYw qf6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715176482; x=1715781282; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qrxifLi18HwIXN/paZijnWPdESXfJJzxe/+u8UtVff4=; b=laaoYDIf/hGzLtT4Jzy2FBxNyamqbVpJYDnp3W8+l9jKraNelfF8RbzDTDwRv2nMxI sPPNPXnpOjs78ZSP4YEBGfx0w118rDwN2EdWlIAn3PjBBMyJWVKf9BIxfn8CWKuDhHbY uCIk4cHbr6xVumbIgeoAqsS6aQ5RFpuQ87SHA/zVyyB0ctZemQ6f0JJvANviBYGoblI9 l1tDJWHJlhr3XE6dxLXWy+CUMO+EnYjYER0e0O8CmFtfo2gNzjMA/E0zfvK/ryJ8cGsF bA3jWvWJBekX1028JaNkCyTuWQGZB+HTyDu4A64E9Rgds64ZYXxAjC9tVnQyslKS+NBc /tyw== X-Forwarded-Encrypted: i=1; AJvYcCWFoxuxHWbpE+e/l9nMYZHMR6qIC5lUlUY3ma4VIYSFC7nCKJIItcjVkgUNuO3X2flpBu8Q7HgG83ASK9q17nnpb/09EVo= X-Gm-Message-State: AOJu0Yzz+CvD71PRVbd9+/ZFAnSIE8NWHJuaebF9sdmIebBCDWVSAY+9 krUsKLR0pIREMI7T0mCQtgd/09R6B6RhHeSSihhkw/hCgdWuUv2JMeUHk6Y2kecumH4K91fLNMh uvQ== X-Google-Smtp-Source: AGHT+IGJRBi1UvMX9yVwIeeKPJ5i4MXrMA7fvNEnU0sh0JI0w6+2/9z2FlMIObyx5JUsUOMhiA6kQPpm0zI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:18c8:b0:dd9:2789:17fb with SMTP id 3f1490d57ef6-debb9cfd19bmr223701276.3.1715176481930; Wed, 08 May 2024 06:54:41 -0700 (PDT) Date: Wed, 8 May 2024 06:54:40 -0700 In-Reply-To: <20240507214254.2787305-5-edliaw@google.com> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240507214254.2787305-1-edliaw@google.com> <20240507214254.2787305-5-edliaw@google.com> Message-ID: Subject: Re: [PATCH v2 4/5] selftests: Drop define _GNU_SOURCE From: Sean Christopherson To: Edward Liaw Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , "=?utf-8?B?QW5kcsOp?= Almeida" , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , "Andreas =?utf-8?Q?F=C3=A4rber?=" , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Tue, May 07, 2024, Edward Liaw wrote: > _GNU_SOURCE is provided by KHDR_INCLUDES, so it should be dropped to > prevent _GNU_SOURCE redefined warnings. ... > diff --git a/tools/testing/selftests/x86/test_syscall_vdso.c b/tools/testing/selftests/x86/test_syscall_vdso.c > index 8965c311bd65..5cd13279bba5 100644 > --- a/tools/testing/selftests/x86/test_syscall_vdso.c > +++ b/tools/testing/selftests/x86/test_syscall_vdso.c > @@ -8,10 +8,6 @@ > * Can be built statically: > * gcc -Os -Wall -static -m32 test_syscall_vdso.c thunks_32.S > */ > -#undef _GNU_SOURCE > -#define _GNU_SOURCE 1 > -#undef __USE_GNU > -#define __USE_GNU 1 AFAICT, manually defining __USE_GNU is frowned upon, so I'm guessing the __USE_GNU stuff is just the result of misguided copy+paste. But it would be nice to get confirmation that this test isn't doing something clever. Or at the very least, explain the removal of __USE_GNU in the changelog. > #include > #include > #include