MPTCP Linux Development
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Mat Martineau <martineau@kernel.org>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next] selftests: mptcp: stop forcing iptables-legacy
Date: Thu, 15 Feb 2024 12:14:34 +0100	[thread overview]
Message-ID: <a2570555-d265-40b0-b2d8-c871799f7751@kernel.org> (raw)
In-Reply-To: <513aac1d-35e2-6505-5cf9-b2920fe0e361@kernel.org>

Hi Mat,

On 14/02/2024 20:09, Mat Martineau wrote:
> On Wed, 7 Feb 2024, Matthieu Baerts (NGI0) wrote:
> 
>> Commit 0c4cd3f86a40 ("selftests: mptcp: join: use 'iptables-legacy' if
>> available") and a5a5990c099d ("selftests: mptcp: sockopt: use
> 
> Hi Matthieu -
> 
> You can add the word "commit" right before "a5a5990c099d" in the commit
> message and that will satisfy checkpatch.

Good idea! I ignored the warning because there was already a "Commit"
before -- should have been "commit*s*" in fact --, but best to add this
second 'commit' to avoid a warning on Netdev's patchwork!

> Fine to do that when applying
> this to the topgit tree

Just did that!

> everything else LGTM:
> 
> Reviewed-by: Mat Martineau <martineau@kernel.org>

Thank you for the review!

Now in our tree (feat. for -next):

New patches for t/upstream:
- 55900e5db350: selftests: mptcp: stop forcing iptables-legacy
- Results: ce1856db2249..52e05de42e10 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20240215T111117

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

  reply	other threads:[~2024-02-15 11:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07 18:22 [PATCH mptcp-next] selftests: mptcp: stop forcing iptables-legacy Matthieu Baerts (NGI0)
2024-02-07 19:09 ` selftests: mptcp: stop forcing iptables-legacy: Tests Results MPTCP CI
2024-02-07 19:56 ` MPTCP CI
2024-02-14 19:09 ` [PATCH mptcp-next] selftests: mptcp: stop forcing iptables-legacy Mat Martineau
2024-02-15 11:14   ` Matthieu Baerts [this message]
2024-02-14 20:02 ` selftests: mptcp: stop forcing iptables-legacy: Tests Results MPTCP CI
2024-02-14 20:33 ` MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2570555-d265-40b0-b2d8-c871799f7751@kernel.org \
    --to=matttbe@kernel.org \
    --cc=martineau@kernel.org \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox