From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Geliang Tang <geliang.tang@suse.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v4 07/10] selftests/bpf: add bpf_bkup scheduler
Date: Tue, 31 May 2022 18:11:32 -0700 (PDT) [thread overview]
Message-ID: <a6b9795-7b6-2cb9-f82e-e643bbb79e51@linux.intel.com> (raw)
In-Reply-To: <fb54b554c1897f5205d1e146d0a7d1d25f7a8a4a.1653987929.git.geliang.tang@suse.com>
On Tue, 31 May 2022, Geliang Tang wrote:
> This patch implements the backup flag test scheduler, named bpf_bkup,
> which picks the first non-backup subflow to send data.
>
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> ---
> tools/testing/selftests/bpf/bpf_tcp_helpers.h | 2 +
> .../selftests/bpf/progs/mptcp_bpf_bkup.c | 43 +++++++++++++++++++
> 2 files changed, 45 insertions(+)
> create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_bkup.c
>
> diff --git a/tools/testing/selftests/bpf/bpf_tcp_helpers.h b/tools/testing/selftests/bpf/bpf_tcp_helpers.h
> index 870deb5cf5ed..6fa496a65bef 100644
> --- a/tools/testing/selftests/bpf/bpf_tcp_helpers.h
> +++ b/tools/testing/selftests/bpf/bpf_tcp_helpers.h
> @@ -234,6 +234,8 @@ extern void tcp_cong_avoid_ai(struct tcp_sock *tp, __u32 w, __u32 acked) __ksym;
> #define MPTCP_SUBFLOWS_MAX 8
>
> struct mptcp_subflow_context {
> + __u32 padding : 12,
> + backup : 1;
Is the padding required? It looks like the BTF code might know how to
handle bitfield members.
- Mat
> bool scheduled;
> } __attribute__((preserve_access_index));
>
> diff --git a/tools/testing/selftests/bpf/progs/mptcp_bpf_bkup.c b/tools/testing/selftests/bpf/progs/mptcp_bpf_bkup.c
> new file mode 100644
> index 000000000000..ad2b2b4de8a5
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/mptcp_bpf_bkup.c
> @@ -0,0 +1,43 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (c) 2022, SUSE. */
> +
> +#include <linux/bpf.h>
> +#include "bpf_tcp_helpers.h"
> +
> +char _license[] SEC("license") = "GPL";
> +
> +SEC("struct_ops/mptcp_sched_bkup_init")
> +void BPF_PROG(mptcp_sched_bkup_init, const struct mptcp_sock *msk)
> +{
> +}
> +
> +SEC("struct_ops/mptcp_sched_bkup_release")
> +void BPF_PROG(mptcp_sched_bkup_release, const struct mptcp_sock *msk)
> +{
> +}
> +
> +void BPF_STRUCT_OPS(bpf_bkup_get_subflow, const struct mptcp_sock *msk,
> + struct mptcp_sched_data *data)
> +{
> + int nr = 0;
> +
> + for (int i = 0; i < MPTCP_SUBFLOWS_MAX; i++) {
> + if (!data->contexts[i])
> + break;
> +
> + if (!data->contexts[i]->backup) {
> + nr = i;
> + break;
> + }
> + }
> +
> + data->contexts[nr]->scheduled = 1;
> +}
> +
> +SEC(".struct_ops")
> +struct mptcp_sched_ops bkup = {
> + .init = (void *)mptcp_sched_bkup_init,
> + .release = (void *)mptcp_sched_bkup_release,
> + .get_subflow = (void *)bpf_bkup_get_subflow,
> + .name = "bpf_bkup",
> +};
> --
> 2.34.1
>
>
>
--
Mat Martineau
Intel
next prev parent reply other threads:[~2022-06-01 1:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 9:09 [PATCH mptcp-next v4 00/10] BPF packet scheduler Geliang Tang
2022-05-31 9:09 ` [PATCH mptcp-next v4 01/10] Squash to "mptcp: add struct mptcp_sched_ops" Geliang Tang
2022-06-01 0:38 ` Mat Martineau
2022-05-31 9:09 ` [PATCH mptcp-next v4 02/10] Squash to "mptcp: add sched in mptcp_sock" Geliang Tang
2022-05-31 9:09 ` [PATCH mptcp-next v4 03/10] Squash to "mptcp: add get_subflow wrappers" Geliang Tang
2022-06-01 0:59 ` Mat Martineau
2022-05-31 9:09 ` [PATCH mptcp-next v4 04/10] Squash to "mptcp: add bpf_mptcp_sched_ops" Geliang Tang
2022-05-31 9:09 ` [PATCH mptcp-next v4 05/10] Squash to "selftests/bpf: add bpf_first scheduler" Geliang Tang
2022-05-31 9:09 ` [PATCH mptcp-next v4 06/10] Squash to "selftests/bpf: add bpf_first test" Geliang Tang
2022-05-31 9:09 ` [PATCH mptcp-next v4 07/10] selftests/bpf: add bpf_bkup scheduler Geliang Tang
2022-06-01 1:11 ` Mat Martineau [this message]
2022-05-31 9:09 ` [PATCH mptcp-next v4 08/10] selftests/bpf: add bpf_backup test Geliang Tang
2022-05-31 9:24 ` Geliang Tang
2022-05-31 9:09 ` [PATCH mptcp-next v4 09/10] selftests/bpf: add bpf_rr scheduler Geliang Tang
2022-05-31 9:09 ` [PATCH mptcp-next v4 10/10] selftests/bpf: add bpf_rr test Geliang Tang
2022-05-31 9:21 ` selftests/bpf: add bpf_rr test: Build Failure MPTCP CI
2022-05-31 10:39 ` selftests/bpf: add bpf_rr test: Tests Results MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6b9795-7b6-2cb9-f82e-e643bbb79e51@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=geliang.tang@suse.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox