From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Gang Yan <yangang@kylinos.cn>
Subject: Re: [RESEND mptcp-next v2 1/2] mptcp: check desc->count in read_sock
Date: Thu, 26 Mar 2026 19:21:30 +0100 [thread overview]
Message-ID: <a8f35df2-e109-4c9f-aff4-c23c49f6ffbd@kernel.org> (raw)
In-Reply-To: <b404cbca4b0d30f82c56f65b38e1c2038bd7e5fe.1773740635.git.tanggeliang@kylinos.cn>
Hi Gang,
On 17/03/2026 10:44, Geliang Tang wrote:
> From: Gang Yan <yangang@kylinos.cn>
>
> In __tcp_read_sock(), it checks whether desc->count equals 0 within the
> loop and breaks the loop if true. This check should also be synchronized
> to __mptcp_read_sock().
This description sounds "strange":
- Is this a fix or an optimisation? i.e. is this check needed for some
reason?
→ If yes, please explain why in the commit message, and eventually add
a Fixes tag.
- Or is it just some extra code that is not needed for MPTCP, but
doesn't hurt
→ If yes, do we really need it?
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2026-03-26 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 9:44 [RESEND mptcp-next v2 0/2] add tcp_recv_should_stop helper Geliang Tang
2026-03-17 9:44 ` [RESEND mptcp-next v2 1/2] mptcp: check desc->count in read_sock Geliang Tang
2026-03-26 18:21 ` Matthieu Baerts [this message]
2026-03-17 9:44 ` [RESEND mptcp-next v2 2/2] tcp: add recv_should_stop helper Geliang Tang
2026-03-26 18:29 ` Matthieu Baerts
2026-03-17 11:13 ` [RESEND mptcp-next v2 0/2] add tcp_recv_should_stop helper MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8f35df2-e109-4c9f-aff4-c23c49f6ffbd@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=yangang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox