Re: [RFC mptcp-next v4 00/10] MPTCP KTLS support

Matthieu Baerts
2025-12-18T17:42:22Z

Hi Geliang,

On 12/12/2025 03:27, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> v4:
> - split "tls: add MPTCP protocol support" into smaller, more
> focused patches.
> - a new mptcp_inq helper has been implemented instead of directly
> using mptcp_inq_hint to fix the issue mentioned in [1].
> - add sk_is_msk helper.
> - the 'expect' parameter will no longer be added to sock_test_tcpulp.
> Instead, SOCK_TEST_TCPULP items causing the tests failure will be
> directly removed.
> - remove the "TCP KTLS" tests, keeping only the MPTCP-related ones.

Thank you for the new version.

We briefly looked at the series with Mat yesterday, and we think that
this series would be better accepted by the KTLS maintainers if function
pointers are used instead of all the sk_is_msk() you added in many
places. In other words, adding a new layer, where "struct tls_strparser"
(or another one?) would have new fields with function pointer to call
tcp_inq() or mptcp_inq(), etc. e.g. strp->ops->tcp_inq(strp->sk).

MPTCP would then only be checked once at the initialisation, not before
each call.

Notes: If adding an indirection is an issue for the KTLS maintainers,
INDIRECT_CALL_*(...) macros can be used. Also, it might be good to send
the RFC to KTLS people, but probably best to wait for the read-sock
series to be in net-next? But if you are not sure about the new
suggested way, I guess it is always possible to email KTLS maintainers,
and ask for their feedback.

Cheers,
Matt
--