From: Matthieu Baerts <matttbe@kernel.org>
To: Mat Martineau <martineau@kernel.org>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-net] selftests: mptcp: simult flows: re-adapt BW
Date: Fri, 9 Feb 2024 15:16:46 +0100 [thread overview]
Message-ID: <aa5316a3-2bee-40c6-87a8-a9eb1fa0e7d8@kernel.org> (raw)
In-Reply-To: <196d5d2c-39c2-b2d9-1104-75bd4b7d6af2@kernel.org>
Hi Mat,
On 09/02/2024 01:30, Mat Martineau wrote:
> On Thu, 8 Feb 2024, Matthieu Baerts (NGI0) wrote:
>
>> Recently, the bandwidth in simult flows selftest has been reduced. The
>> idea was to improve the situation in slow environments. It helped in
>> some, but not in all of them. With a longer transfer, it is also
>> possible to get more instabilities along the way.
>>
>> We can increase a bit the rate limit for the unbalanced bandwidth cases,
>> but limit the total of the two links to 20 Mbps, like the balanced
>> bandwidth cases. The same 3:1 ratio is still being used like before, not
>> to change the nature of the test.
>>
>> Fixes: 5e2f3c65af47 ("selftests: mptcp: decrease BW in simult flows")
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>
> Looks reasonable, thanks Matthieu.
>
> Reviewed-by: Mat Martineau <martineau@kernel.org>
Thank you for the review!
Now in our tree (fix for -net):
New patches for t/upstream-net and t/upstream:
- 7e6c60f9e796: selftests: mptcp: simult flows: re-adapt BW
- Results: 6075087dd1c3..bef0b46af378 (export-net)
- Results: 081844c2b78a..78a4d8e40bf5 (export)
Tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20240209T140100
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20240209T140100
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-02-09 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 9:14 [PATCH mptcp-net] selftests: mptcp: simult flows: re-adapt BW Matthieu Baerts (NGI0)
2024-02-08 10:06 ` selftests: mptcp: simult flows: re-adapt BW: Tests Results MPTCP CI
2024-02-08 10:40 ` MPTCP CI
2024-02-09 0:30 ` [PATCH mptcp-net] selftests: mptcp: simult flows: re-adapt BW Mat Martineau
2024-02-09 14:16 ` Matthieu Baerts [this message]
2024-02-09 1:15 ` selftests: mptcp: simult flows: re-adapt BW: Tests Results MPTCP CI
2024-02-09 2:19 ` MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa5316a3-2bee-40c6-87a8-a9eb1fa0e7d8@kernel.org \
--to=matttbe@kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox