From: Matthieu Baerts <matttbe@kernel.org>
To: Jason Xing <kerneljasonxing@gmail.com>,
edumazet@google.com, dsahern@kernel.org, martineau@kernel.org,
geliang@kernel.org, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net, rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, atenart@kernel.org,
horms@kernel.org
Cc: mptcp@lists.linux.dev, netdev@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next v8 6/7] mptcp: introducing a helper into active reset logic
Date: Tue, 23 Apr 2024 12:02:18 +0200 [thread overview]
Message-ID: <aabaa38e-3201-4f5b-8328-5b4348685f71@kernel.org> (raw)
In-Reply-To: <20240423072137.65168-7-kerneljasonxing@gmail.com>
Hi Jason,
On 23/04/2024 09:21, Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
>
> Since we have mapped every mptcp reset reason definition in enum
> sk_rst_reason, introducing a new helper can cover some missing places
> where we have already set the subflow->reset_reason.
>
> Note: using SK_RST_REASON_NOT_SPECIFIED is the same as
> SK_RST_REASON_MPTCP_RST_EUNSPEC. They are both unknown. So we can convert
> it directly.
It looks good to me, thanks:
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-04-23 10:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 7:21 [PATCH net-next v8 0/7] Implement reset reason mechanism to detect Jason Xing
2024-04-23 7:21 ` [PATCH net-next v8 1/7] net: introduce rstreason to detect why the RST is sent Jason Xing
2024-04-23 9:59 ` Matthieu Baerts
2024-04-23 7:21 ` [PATCH net-next v8 2/7] rstreason: prepare for passive reset Jason Xing
2024-04-23 10:00 ` Matthieu Baerts
2024-04-23 7:21 ` [PATCH net-next v8 3/7] rstreason: prepare for active reset Jason Xing
2024-04-23 10:00 ` Matthieu Baerts
2024-04-23 7:21 ` [PATCH net-next v8 4/7] tcp: support rstreason for passive reset Jason Xing
2024-04-23 7:21 ` [PATCH net-next v8 5/7] mptcp: " Jason Xing
2024-04-23 10:02 ` Matthieu Baerts
2024-04-23 10:57 ` Jason Xing
2024-04-23 7:21 ` [PATCH net-next v8 6/7] mptcp: introducing a helper into active reset logic Jason Xing
2024-04-23 10:02 ` Matthieu Baerts [this message]
2024-04-23 7:21 ` [PATCH net-next v8 7/7] rstreason: make it work in trace world Jason Xing
2024-04-23 8:15 ` [PATCH net-next v8 0/7] Implement reset reason mechanism to detect MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aabaa38e-3201-4f5b-8328-5b4348685f71@kernel.org \
--to=matttbe@kernel.org \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox