From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93EF41386C9 for ; Thu, 31 Oct 2024 16:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730392383; cv=none; b=miPIcq6ANGqGcurhPppGzPL0jlEcSTvIrMA/cuFJ+nWEX9TqzPaZQOQ3jYpOvdDwDON90pC94UPFRCfvD2LuEIXjqw4O7f/JzubsuLA63TOCn6970iXF/D1GFTTQs0S/VQH3xFAfbmf2jSwLRC2rOpfYNtKWHXjgeI/hRVbm+Fo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730392383; c=relaxed/simple; bh=GXgUskfp6llZhhIxyLc/+lKhvRKxIRXzIcni0wj9n3I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GfBkdnU07IHPOSTGelT5/SjOsqa/eV42kVq5/sRsYm9HzMzVEMSZ3FftjMx1bOWeO15YdBrqderVOtTs7hK7OojAHI/zcNGTrzImDUK1eJWBwD+DgrFzYtndjkbuZzi9iPJXiclQ5AQ4yMpE2iIvMCIV41a9x5H783ydnqwY5zI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=me2xsZNw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="me2xsZNw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65AF7C4CED2; Thu, 31 Oct 2024 16:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730392383; bh=GXgUskfp6llZhhIxyLc/+lKhvRKxIRXzIcni0wj9n3I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=me2xsZNw8ObXILT8ZuirNFcqIZHS/BvCx7ebcldttkUdPuQwulzhm09cG/2nmUv5U oFzwxp6sKFLUaFFhASoixRvkLChK/JbtIwsKHz8vgHQZxtluBvGpt6NzSteaJINexE XyyXwsM55g9cHEQbedBDc6rqqHfTbyRuSFSOpKDndIhR1HCJiLGMelC1Pm3+mcfMTH D79vRiYlFjuN56BMrA36ydQXYqccApyRNc2jrrqKKOMqBakCOVch0miWU74GJ2PAzQ Iyqasui0HcUZCWOiCDITRxmjgM6rohh6yxBeY/zNfyXj4LOb06lQdKfeCNTOP6QIIO RF1oaAU7xUfOQ== Message-ID: Date: Thu, 31 Oct 2024 17:33:00 +0100 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH mptcp-next v2 07/36] mptcp: make three pm wrappers static Content-Language: en-GB To: Geliang Tang , mptcp@lists.linux.dev Cc: Geliang Tang References: <6a0fc4027e27a2bdbbaea2997a5489399ea0fc7d.1729588019.git.tanggeliang@kylinos.cn> <18ade37f-5557-4ff0-ae1f-1b4cd6b66e97@kernel.org> <00cbea0123cece1f64b198a9f8109075f6f74f59.camel@kernel.org> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <00cbea0123cece1f64b198a9f8109075f6f74f59.camel@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Geliang, On 31/10/2024 08:58, Geliang Tang wrote: > On Wed, 2024-10-30 at 19:31 +0100, Matthieu Baerts wrote: >> Hi Geliang, >> >> (I'm still reviewing the series, thank you for your patience. Please >> wait for me to finish it before sending a v3.) >> >> On 22/10/2024 11:14, Geliang Tang wrote: >>> From: Geliang Tang >>> >>> Three path manager wrappers, mptcp_pm_get_addr(), >>> mptcp_pm_dump_addr() and >>> mptcp_pm_set_flags() are used to switch the interfaces between in- >>> kernel >>> PM and userspace PM. These wrappers are defined in pm.c but only >>> used in >>> pm_netlink.c. It makes more sense to move them to pm_netlink.c and >>> make >>> them all static. >> >> These three helpers are calling userspace PM code, that looks >> "strange" >> to do that from pm_netlink. > > I agree. > >> >> I didn't check, but would it not make more sense to move all the >> _doit() >> functions calling these helpers to pm.c? Also, do we still these >> helpers >> you were moving? Can we not instead remove them, and move their code >> directly in the _doit() functions if you see what I mean? >> >>   int mptcp_pm_nl_get_addr_doit(...) >>   { >>       if (info->attrs[MPTCP_PM_ATTR_TOKEN]) >>           return mptcp_userspace_pm_get_addr(skb, info); >>       return mptcp_pm_nl_get_addr(skb, info); >>   } >> >> (in pm.c) >> >> WDYT? > > I prefer to drop this patch and keep the code as is. Up to you. I think it still makes sense not to have a "public" function simply calling another "public" one with the same arguments. But the code can also stay like that for the moment, no problem. Cheers, Matt -- Sponsored by the NGI0 Core fund.