From: Breno Leitao <leitao@debian.org>
To: "Cen Zhang (Microsoft)" <blbllhy@gmail.com>
Cc: AutonomousCodeSecurity@microsoft.com, andriin@fb.com,
ast@kernel.org, bpf@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, geliang@kernel.org, horms@kernel.org,
kafai@fb.com, kuba@kernel.org, kuniyu@google.com,
kys@microsoft.com, linux-kernel@vger.kernel.org,
martineau@kernel.org, matttbe@kernel.org, mptcp@lists.linux.dev,
ncardwell@google.com, netdev@vger.kernel.org, pabeni@redhat.com,
stable@vger.kernel.org, tgopinath@linux.microsoft.com,
xmei5@asu.edu, yhs@fb.com
Subject: Re: [PATCH net v3 1/2] tcp: fix use-after-free in do_tcp_getsockopt(TCP_CONGESTION)
Date: Fri, 28 Aug 2026 07:17:07 -0700 [thread overview]
Message-ID: <apGQkAXE7ZkLkqBi@gmail.com> (raw)
In-Reply-To: <20260828130212.32968-1-blbllhy@gmail.com>
On Fri, Aug 28, 2026 at 09:02:12AM -0400, Cen Zhang (Microsoft) wrote:
> > nit: Do you need to zero this string? It will be safely overwritten
> > below, no?
>
> Thanks for catching this. That initialization is unnecessary. Would
> you prefer a new version for this, or are you okay with keeping it
> as-is? I may need a few days before I can send a new version due to an
> ongoing email account approval process.
Right, this is just a nit, as I noted above.
We could leave it for the netdev maintainers to flag, but given how
strict netdev's review process is, I wouldn't be surprised if they
still ask for it to be cleaned up.
next prev parent reply other threads:[~2026-08-28 14:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 23:55 [PATCH net v3 0/2] tcp: fix use-after-free in do_tcp_getsockopt() Cen Zhang (Microsoft)
2026-08-27 23:55 ` [PATCH net v3 1/2] tcp: fix use-after-free in do_tcp_getsockopt(TCP_CONGESTION) Cen Zhang (Microsoft)
2026-08-28 3:26 ` Jiayuan Chen
2026-08-28 9:41 ` Matthieu Baerts
2026-08-28 12:38 ` Breno Leitao
2026-08-28 13:02 ` Cen Zhang (Microsoft)
2026-08-28 14:17 ` Breno Leitao [this message]
2026-08-28 23:55 ` sashiko-bot
2026-08-27 23:55 ` [PATCH net v3 2/2] tcp: fix use-after-free in do_tcp_getsockopt(TCP_CC_INFO) Cen Zhang (Microsoft)
2026-08-28 3:14 ` Jiayuan Chen
2026-08-28 9:42 ` Matthieu Baerts
2026-08-28 1:05 ` [PATCH net v3 0/2] tcp: fix use-after-free in do_tcp_getsockopt() MPTCP CI
2026-08-29 5:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apGQkAXE7ZkLkqBi@gmail.com \
--to=leitao@debian.org \
--cc=AutonomousCodeSecurity@microsoft.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=blbllhy@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tgopinath@linux.microsoft.com \
--cc=xmei5@asu.edu \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox