Re: [PATCH mptcp-next v2 2/3] mptcp: allow overridden write_space to be invoked

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 03/02/2026 11:56, Matthieu Baerts wrote:
> On 03/02/2026 11:31, Geliang Tang wrote:
>> Hi Matt,
>>
>> Thanks for your reply.
>>
>> On Tue, 2026-02-03 at 10:42 +0100, Matthieu Baerts wrote:
>>> Hi Geliang,
>>>
>>> On 03/02/2026 07:54, Geliang Tang wrote:
>>>> Hi Matt, Mat, Paolo,
>>>>
>>>> On Sun, 2026-01-04 at 13:29 +0800, Geliang Tang wrote:
>>>>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>>>>
>>>>> psock may override its own sk_write_space functions. This patch
>>>>> ensures
>>>>> that the overridden sk_write_space can be invoked by MPTCP.
>>>>>
>>>>> Note: This patch was initially included in the NVME MPTCP set.
>>>>
>>>> This patch was initially developed to resolve the "timeout" errors
>>>> observed in the NVMe MPTCP tests described in [1], because NVMe TCP
>>>> overrides its own sk_write_space. During subsequent development, I
>>>> discovered that not only NVMe TCP overrides its own sk_write_space,
>>>> but
>>>> KTLS and psock also override it. 
>>>>
>>>> Therefore, this patch is needed in all three series. To reduce
>>>> dependencies between these three series, I propose to merge this
>>>> patch
>>>> into the mainline first.
>>>
>>> Just to be sure, when you say "mainline", do you mean our MPTCP tree
>>> with the export branch?
>>>
>>> Because we are at the end of a cycle here, my priority is to flush
>>> patches that are ready or fix issues. If I'm not mistaken, this patch
>>> is
>>> needed for new features that are not in our tree, not in net or net-
>>> next
>>> trees, right?
>>
>> Yes, it is needed for new features. In this case, merging it into the
>> export branch first is also an option. It can be sent to net-next in
>> the next cycle. I plan to submit the KTLS series and the NVMe series to
>> the KTLS and NVMe communities for feedback respectively. If this
>> write_space patch enters net-next early, it would be more convenient.
> 
> I see.
> 
> Is only this patch 2/3 from this series needed? Or the whole series?

I just applied this patch (only this one) and I will try to send it this
cycle.

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.