Re: [PATCH mptcp-net v3 3/6] Squash-to: "mptcp: invoke MP_FAIL response when needed"

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Fri, 17 Jun 2022, Paolo Abeni wrote:

> On Fri, 2022-06-17 at 12:05 +0200, Paolo Abeni wrote:
>> diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
>> index 98b12a9c4eb5..c82a9a6e0267 100644
>> --- a/net/mptcp/subflow.c
>> +++ b/net/mptcp/subflow.c
>> @@ -1158,6 +1158,33 @@ static bool subflow_can_fallback(struct mptcp_subflow_context *subflow)
>>  		return !subflow->fully_established;
>>  }
>>
>> +static void mptcp_subflow_fail(struct mptcp_sock *msk, struct sock *ssk)
>> +{
>> +	struct mptcp_subflow_context *subflow = mptcp_subflow_ctx(ssk);
>> +	unsigned long fail_tout;
>> +
>> +	/* grecefull failure can happen only on the MPC subflow */
>> +	if (WARN_ON_ONCE(ssk != READ_ONCE(msk->first)))
>> +		return;
>> +
>> +	/* since the close timeout take precedence on the fail one,
>> +	 * no need to starte the latter when the first is already set
>
> Typo here ("starte"). It would be great if it could be addressed
> without reposting the whole series... A later squash-to patch could be
> ok?
>

Typo fix via squash or edit is fine by me. Also, grecefull->graceful a 
few lines earlier.

--
Mat Martineau
Intel