Re: [PATCH mptcp-next v2 00/13] BPF packet scheduler updates part 2

[Mat Martineau <martineau@kernel.org>]

On Tue, 18 Jul 2023, Geliang Tang wrote:

> v2:
> - Init nr to -1 for bpf_bkup and bpf_stale.
> - Update has_bytes_sent() to make sure only one item showed in 'ss -it',
>  this needs to start server with PORT_1.
> - Rename to bpf_mptcp_subflow_memory_free() and
>  bpf_mptcp_subflow_queues_empty().
> - Simplify div_u64().
> - Move mptcp_subflow_set_stale() to kernel space. stale is a bit filed,
>  I haven't found a way to set a bit filed in BPF context yet, so set it
>  in kernel space.
> - Sync with new bpf_tcp_ca.c.
>
> Geliang Tang (13):


Thanks for the patches Geliang.

I think the first 7 patches are ok to squash on the export branch:

>  Squash to "bpf: Add bpf_mptcp_sched_ops"
>  Squash to "selftests/bpf: Add bpf scheduler test"
>  Squash to "selftests/bpf: Add bpf_first test"
>  Squash to "selftests/bpf: Add bpf_bkup scheduler"
>  Squash to "selftests/bpf: Add bpf_bkup test"
>  Squash to "selftests/bpf: Add bpf_rr test"
>  Squash to "selftests/bpf: Add bpf_red test"

I have questions for a few of the remaining patches, I will reply 
separately to those.

- Mat

>  mptcp: add subflow_set_stale helper
>  selftests/bpf: Add bpf_stale scheduler
>  selftests/bpf: Add bpf_stale test
>  bpf: Export more bpf_burst related functions
>  selftests/bpf: Add bpf_burst scheduler
>  selftests/bpf: Add bpf_burst test
>
> net/mptcp/bpf.c                               |  44 ++--
> net/mptcp/protocol.c                          |   4 +-
> net/mptcp/protocol.h                          |   6 +
> net/mptcp/sched.c                             |   6 +
> tools/testing/selftests/bpf/bpf_tcp_helpers.h |   7 +-
> .../testing/selftests/bpf/prog_tests/mptcp.c  |  91 +++++++-
> .../selftests/bpf/progs/mptcp_bpf_bkup.c      |   5 +-
> .../selftests/bpf/progs/mptcp_bpf_burst.c     | 197 ++++++++++++++++++
> .../selftests/bpf/progs/mptcp_bpf_stale.c     |  63 ++++++
> 9 files changed, 384 insertions(+), 39 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_burst.c
> create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_stale.c
>
> -- 
> 2.35.3
>
>
>