From: Matthieu Baerts <matttbe@kernel.org>
To: Gang Yan <gang.yan@linux.dev>
Cc: Gang Yan <yangang@kylinos.cn>, mptcp@lists.linux.dev
Subject: Re: [PATCH, mptcp-net] mptcp: fix address removal logic in mptcp_pm_nl_rm_addr
Date: Tue, 4 Nov 2025 15:34:38 +0100 [thread overview]
Message-ID: <bde9ef49-25c6-4892-8952-917ce5ff54a5@kernel.org> (raw)
In-Reply-To: <20251104123416.395362-1-gang.yan@linux.dev>
Hi Gang,
On 04/11/2025 13:34, Gang Yan wrote:
> From: Gang Yan <yangang@kylinos.cn>
>
> Fix inverted WARN_ON_ONCE condition that prevented normal address
> removal counter updates. The current code only executes decrement
> logic when the counter is already 0 (abnormal state), while
> normal removals (counter > 0) are ignored.
Good catch!
For fixes, we need a Fixes tag:
Fixes: 636113918508 ("mptcp: pm: remove '_nl' from
mptcp_pm_nl_rm_addr_received")
Apart from that, it looks good to me:
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
How did you find out about this? I'm surprised out test suite didn't
spot it. By chance, do you have a test that can be used to reproduce
this issue?
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-11-04 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 12:34 [PATCH, mptcp-net] mptcp: fix address removal logic in mptcp_pm_nl_rm_addr Gang Yan
2025-11-04 13:49 ` MPTCP CI
2025-11-04 14:34 ` Matthieu Baerts [this message]
2025-11-05 2:13 ` GangYan
2025-11-05 2:19 ` GangYan
2025-11-05 11:22 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bde9ef49-25c6-4892-8952-917ce5ff54a5@kernel.org \
--to=matttbe@kernel.org \
--cc=gang.yan@linux.dev \
--cc=mptcp@lists.linux.dev \
--cc=yangang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox