From: Paolo Abeni <pabeni@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>, Mat Martineau <martineau@kernel.org>
Cc: Matthieu Baerts <matttbe@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, mptcp@lists.linux.dev
Subject: Re: [PATCH net-next 1/9] mptcp: add a new sysctl for make after break timeout
Date: Wed, 25 Oct 2023 15:48:08 +0200 [thread overview]
Message-ID: <bfd0a37b09540fd3cf4107f9bea1b9efb70d5b33.camel@redhat.com> (raw)
In-Reply-To: <20231024175454.11b3305b@kernel.org>
On Tue, 2023-10-24 at 17:54 -0700, Jakub Kicinski wrote:
> On Mon, 23 Oct 2023 13:44:34 -0700 Mat Martineau wrote:
> > + .procname = "close_timeout",
> > + .maxlen = sizeof(unsigned int),
> > + .mode = 0644,
> > + .proc_handler = proc_dointvec_jiffies,
>
> Silly question - proc_dointvec_jiffies() works fine for unsigned types?
AFAICS, yes: proc_dointvec_jiffies() internally uses
__do_proc_dointvec(), which parses the buffer to a 'long' local
variable and then do_proc_dointvec_jiffies_conv() converts it to
integer taking care of possible overflows.
Cheers,
Paolo
next prev parent reply other threads:[~2023-10-25 13:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 20:44 [PATCH net-next 0/9] mptcp: Features and fixes for v6.7 Mat Martineau
2023-10-23 20:44 ` [PATCH net-next 1/9] mptcp: add a new sysctl for make after break timeout Mat Martineau
2023-10-25 0:54 ` Jakub Kicinski
2023-10-25 13:48 ` Paolo Abeni [this message]
2023-10-23 20:44 ` [PATCH net-next 2/9] mptcp: properly account fastopen data Mat Martineau
2023-10-23 20:44 ` [PATCH net-next 3/9] mptcp: use plain bool instead of custom binary enum Mat Martineau
2023-10-23 20:44 ` [PATCH net-next 4/9] tcp: define initial scaling factor value as a macro Mat Martineau
2023-10-23 20:44 ` [PATCH net-next 5/9] mptcp: give rcvlowat some love Mat Martineau
2023-10-23 20:44 ` [PATCH net-next 6/9] mptcp: use copy_from_iter helpers on transmit Mat Martineau
2023-10-23 20:44 ` [PATCH net-next 7/9] mptcp: consolidate sockopt synchronization Mat Martineau
2023-10-23 20:44 ` [PATCH net-next 8/9] mptcp: ignore notsent_lowat setting at the subflow level Mat Martineau
2023-10-23 20:44 ` [PATCH net-next 9/9] mptcp: refactor sndbuf auto-tuning Mat Martineau
2023-11-02 17:19 ` Eric Dumazet
2023-11-02 18:38 ` Mat Martineau
2023-11-06 7:21 ` Paolo Abeni
2023-11-06 8:18 ` Eric Dumazet
2023-10-25 19:50 ` [PATCH net-next 0/9] mptcp: Features and fixes for v6.7 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfd0a37b09540fd3cf4107f9bea1b9efb70d5b33.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox