From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F3C19474 for ; Tue, 15 Oct 2024 07:27:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728977243; cv=none; b=g9DEfdit2mAmErOCLsj6l+7czuamgoJH2I9veqgy/6TNNPVtnNNvykHkRXMemONZE7sxXLhGq5u4yL1gfLCLErIOWY2GS/YQNK5TY6eXn0g6I+0MH2oVJqwhdcZpNEQxVbMwoemzgrf5t/d96ofIOE7nWMZ2yus363IGIPzuRHQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728977243; c=relaxed/simple; bh=rMA39I60aqJrH2dDh6m6DrAuyAX+BZy6PhELqD3UL1c=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=AvlBuqI6J2bJ41cKtuWxB0wRGsHymWSvdgzpXF732FM2Zp3ssUky6uFgU2d/Slu+MYloRt90yTaNSPBAQYqirmxP8ynZyysZiFW2I5avcVSk42QUQXstauPV4n3PmyS4Yree/uC1pU5oYWFaTe9QNjbFp+3XH3chnyDibLQ3VxQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=B14lhUJx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="B14lhUJx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 912A0C4CEC7; Tue, 15 Oct 2024 07:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728977242; bh=rMA39I60aqJrH2dDh6m6DrAuyAX+BZy6PhELqD3UL1c=; h=Subject:From:To:Date:In-Reply-To:References:From; b=B14lhUJxvs+1BdRGW5s1vnt5jbKNS9lQuSqMAQY9v5+TBFulL9PqxGWlkXT1Iq3Ob O5Q7ezh7gOTFDfjA1A6rYz/Ycwgpks9Rg5YD8bRq00Eg/7RoWMRGKO0OQ59vnhAqDi PmogZTRK4eWSPCOa3su/wNe4qdCtKYTQABgTTn368d78LBIq9TrcpJ2G3RatOrivOo J/5MvFJkHQPpAS2hYTamX3OgF9Fcq4wrGichfxw0bC6SEtHrdrVHm4Hd/0i/brkejq kge2GIYYlag6ErdW+T5wkSKm1ocj1H2pcEHziGEC2vU31aWyl4ff4c0LuSbJBpuKDJ D3lHE3fpK7iCw== Message-ID: Subject: Re: [PATCH mptcp-next v9 0/7] add mptcp_subflow bpf_iter From: Geliang Tang To: Matthieu Baerts , mptcp@lists.linux.dev, Geliang Tang Date: Tue, 15 Oct 2024 15:27:17 +0800 In-Reply-To: <953bf596-94e5-4829-adec-5997e1557487@kernel.org> References: <30504191-4b5f-1a69-08a3-5ae0f444c802@gmail.com> <953bf596-94e5-4829-adec-5997e1557487@kernel.org> Autocrypt: addr=geliang@kernel.org; prefer-encrypt=mutual; keydata=mQINBGWKTg4BEAC/Subk93zbjSYPahLCGMgjylhY/s/R2ebALGJFp13MPZ9qWlbVC8O+X lU/4reZtYKQ715MWe5CwJGPyTACILENuXY0FyVyjp/jl2u6XYnpuhw1ugHMLNJ5vbuwkc1I29nNe8 wwjyafN5RQV0AXhKdvofSIryqm0GIHIH/+4bTSh5aB6mvsrjUusB5MnNYU4oDv2L8MBJStqPAQRLl P9BWcKKA7T9SrlgAr0VsFLIOkKOQPVTCnYxn7gfKogH52nkPAFqNofVB6AVWBpr0RTY7OnXRBMInM HcjVG4I/NFn8Cc7oaGaWHqX/yHAufJKUsldieQVFd7C/SI8jCUXdkZxR0Tkp0EUzkRc/TS1VwWHav 0x3oLSy/LGHfRaIC/MqdGVqgCnm6wapUt7f/JHloyIyKJBGBuHCLMpN6n/kNkSCzyZKV7h6Vw1OL5 18p0U3Optyakoh95KiJsKzcd3At/eftQGlNn5WDflHV1+oMdW2sRgfVDPrYeEcYI5IkTc3LRO6ucp VCm9/+poZSHSXMI/oJ6iXMJE8k3/aQz+EEjvc2z0p9aASJPzx0XTTC4lciTvGj62z62rGUlmEIvU2 3wWH37K2EBNoq+4Y0AZsSvMzM+CcTo25hgPaju1/A8ErZsLhP7IyFT17ARj/Et0G46JRsbdlVJ/Pv X+XIOc2mpqx/QARAQABtCVHZWxpYW5nIFRhbmcgPGdlbGlhbmcudGFuZ0BsaW51eC5kZXY+iQJUBB MBCgA+FiEEZiKd+VhdGdcosBcafnvtNTGKqCkFAmWKTg4CGwMFCRLMAwAFCwkIBwIGFQoJCAsCBBY CAwECHgECF4AACgkQfnvtNTGKqCmS+A/9Fec0xGLcrHlpCooiCnNH0RsXOVPsXRp2xQiaOV4vMsvh G5AHaQLb3v0cUr5JpfzMzNpEkaBQ/Y8Oj5hFOORhTyCZD8tY1aROs8WvbxqvbGXHnyVwqy7AdWelP +0lC0DZW0kPQLeel8XvLnm9Wm3syZgRGxiM/J7PqVcjujUb6SlwfcE3b2opvsHW9AkBNK7v8wGIcm BA3pS1O0/anP/xD5s5L7LIMADVB9MqQdeLdFU+FFdafmKSmcP9A2qKHAvPBUuQo3xoBOZR3DMqXIP kNCBfQGkAx5tm1XYli1u3r5tp5QCRbY5LSkntMNJJh0eWLU8I+zF6NWhqNhHYRD3zc1tiXlG5E0ob pX02Dy25SE2zB3abCRdAK30nCI4lMyMCcyaeFqvf6uhiugLiuEPRRRdJDWICOLw6KOFmxWmue1F71 k08nj5PQMWQUX3X2K6jiOuoodYwnie/9NsH3DBHIVzVPWASFd6JkZ21i9Ng4ie+iQAveRTCeCCF6V RORJR0R8d7mI9+1eqhNeKzs21gQPVf/KBEIpwPFDjOdTwS/AEQQyhB+5ALeYpNgfKl2p30C20VRfJ GBaTc4ReUXh9xbUx5OliV69iq9nIVIyculTUsbrZX81Gz6UlbuSzWc4JclWtXf8/QcOK31wputde7 Fl1BTSR4eWJcbE5Iz2yzgQu0IUdlbGlhbmcgVGFuZyA8Z2VsaWFuZ0BrZXJuZWwub3JnPokCVAQTA QoAPhYhBGYinflYXRnXKLAXGn577TUxiqgpBQJlqclXAhsDBQkSzAMABQsJCAcCBhUKCQgLAgQWAg MBAh4BAheAAAoJEH577TUxiqgpaGkP/3+VDnbu3HhZvQJYw9a5Ob/+z7WfX4lCMjUvVz6AAiM2atD yyUoDIv0fkDDUKvqoU9BLU93oiPjVzaR48a1/LZ+RBE2mzPhZF201267XLMFBylb4dyQZxqbAsEhV c9VdjXd4pHYiRTSAUqKqyamh/geIIpJz/cCcDLvX4sM/Zjwt/iQdvCJ2eBzunMfouzryFwLGcOXzx OwZRMOBgVuXrjGVB52kYu1+K90DtclewEgvzWmS9d057CJztJZMXzvHfFAQMgJC7DX4paYt49pNvh cqLKMGNLPsX06OR4G+4ai0JTTzIlwVJXuo+uZRFQyuOaSmlSjEsiQ/WsGdhILldV35RiFKe/ojQNd 4B4zREBe3xT+Sf5keyAmO/TG14tIOCoGJarkGImGgYltTTTM6rIk/wwo9FWshgKAmQyEEiSzHTSnX cGbalD3Do89YRmdG+5eP7HQfsG+VWdn8IH6qgIvSt8GOw6RfSP7omMXvXji1VrbWG4LOFYcsKTN+d GDhl8LmU0y44HejkCzYj/b28MvNTiRVfucrmZMGgI8L5A4ZwQ3Inv7jY13GZSvTb7PQIbqMcb1P3S qWJFodSwBg9oSw21b+T3aYG3z3MRCDXDlZAJONELx32rPMdBva8k+8L+K8gc7uNVH4jkMPkP9jPnV Px+2P2cKc7LXXedb/qQ3M Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.52.3-0ubuntu1 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Matt, Thanks for this review. On Mon, 2024-10-14 at 18:08 +0200, Matthieu Baerts wrote: > Hi Geliang, > > On 09/10/2024 12:05, MPTCP CI wrote: > > Hi Geliang, > > > > Thank you for your modifications, that's great! > > > > But sadly, our CI spotted some issues with it when trying to build > > it. > > > > You can find more details there: > > > >   > > https://github.com/multipath-tcp/mptcp_net-next/actions/runs/11252652867 > > I was looking at applying this series, but there are some issues > reported by the CI: > >   warning: symbol 'bpf_*mptcp_*' was not declared. Should it be > static? > > Could it be possible to have a fix for that please before applying > the > series? No fix is ​​needed, just ignore these warnings. This error is also reported in other places: $ make C=1 -o net/socket.o CALL scripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers DESCEND bpf/resolve_btfids INSTALL libsubcmd_headers CC net/socket.o CHECK net/socket.c net/socket.c:1704:21: warning: symbol 'update_socket_protocol' was not declared. Should it be static? It seems that it is because "-Wmissing-declarations" is not recognized by sparse > > I guess you are missing __bpf_kfunc_start_defs() and > __bpf_kfunc_end_defs() around the declaration of the BPF dedicated > kfunc, no? No. __bpf_kfunc_start_defs() and __bpf_kfunc_end_defs() are indeed used in patch 2. > > > Also, where should I apply these patches? Before "mptcp: add > sched_data > helpers"? Yes, before "mptcp: add sched_data helpers", after "selftests/bpf: Add mptcp subflow subtest". > But then there should not be any dependences on the BPF > scheduler work (and I think that would be better without this > dependence, see my comment on patch 4/7) This set doesn't have any dependence on the BPF packet scheduler since the selftest is added as a ftrace. It somehow depends on packet scheduler since it invoke some packet scheduler functions such as mptcp_subflow_active() and bpf_mptcp_subflow_tcp_sock(). > > Cheers, > Matt