From: Mat Martineau <martineau@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH v4 mptcp-next 4/6] mptcp: better rcv space initialization
Date: Fri, 14 Nov 2025 17:32:36 -0800 (PST) [thread overview]
Message-ID: <c279328d-9ae5-fb26-4d71-d23d887a44da@kernel.org> (raw)
In-Reply-To: <add0910a988cd8f45b7c3f5c76dea0fc3f4ee666.1762940290.git.pabeni@redhat.com>
On Wed, 12 Nov 2025, Paolo Abeni wrote:
> Each additional subflow can overshot the rcv space by a full rcv wnd,
> as the TCP socket at creation time will announce such window even if
> the MPTCP-level window is closed.
>
> Underestimating the initial real rcv space can overshot the initial rcv
> win increase significantly.
>
> Keep track explicitly of the rcv space contribution by newly created
> subflow, updating rcvq_space.space accordingly for every successfully
> completed subflow handshake.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> net/mptcp/protocol.c | 44 ++++++++++++++++++++++++++++++--------------
> net/mptcp/protocol.h | 30 ++++++++++++++++++++++++++++++
> net/mptcp/subflow.c | 3 +++
> 3 files changed, 63 insertions(+), 14 deletions(-)
Reviewed-by: Mat Martineau <martineau@kernel.org>
next prev parent reply other threads:[~2025-11-15 1:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 9:41 [PATCH v4 mptcp-next 0/6] mptcp: autotune related improvement Paolo Abeni
2025-11-12 9:41 ` [PATCH v4 mptcp-next 1/6] trace: mptcp: add mptcp_rcvbuf_grow tracepoint Paolo Abeni
2025-11-15 1:31 ` Mat Martineau
2025-11-12 9:41 ` [PATCH v4 mptcp-next 2/6] mptcp: fix receive space timestamp initialization Paolo Abeni
2025-11-15 1:32 ` Mat Martineau
2025-11-12 9:41 ` [PATCH v4 mptcp-next 3/6] mptcp: consolidate rcv space init Paolo Abeni
2025-11-15 1:32 ` Mat Martineau
2025-11-12 9:41 ` [PATCH v4 mptcp-next 4/6] mptcp: better rcv space initialization Paolo Abeni
2025-11-15 1:32 ` Mat Martineau [this message]
2025-11-12 9:41 ` [PATCH v4 mptcp-next 5/6] mptcp: better mptcp-level RTT estimator Paolo Abeni
2025-11-15 1:43 ` Mat Martineau
2025-11-17 20:34 ` Paolo Abeni
2025-11-12 9:41 ` [PATCH v4 mptcp-next 6/6] mptcp: add receive queue awareness in tcp_rcv_space_adjust() Paolo Abeni
2025-11-15 1:32 ` Mat Martineau
2025-11-12 10:45 ` [PATCH v4 mptcp-next 0/6] mptcp: autotune related improvement MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c279328d-9ae5-fb26-4d71-d23d887a44da@kernel.org \
--to=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox