Re: [PATCH mptcp-next v2 1/2] mptcp: allow priviledged operations from user namespaces

[Thomas Haller <thaller@redhat.com>]

Hi Matthieu,



On Thu, 2022-08-11 at 12:34 +0200, Matthieu Baerts wrote:
> Hi Thomas, Mat, Florian,
> 
> On 11/08/2022 01:08, Mat Martineau wrote:
> ...
> 
> > 
> > Thanks Thomas, looks good:
> > 
> > Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> 
> Thank you for the patches and the reviews!
> 
> > [...]
> 
> 
> I initially thought it was more a bug-fix but I also agree with
> Florian.
> Also I see that the two mentioned commits above don't have a Fixes
> tag.
> 
> The only exception I found and related to this flag was for l2tp: the
> commit 2abe05234f2e ("l2tp: Allow management of tunnels and session
> in
> user namespace") has been selected by davem and backported to v5.4.
> 
> https://lore.kernel.org/stable/20200417.105100.821338189941807731.davem@davemloft.net/
> (see patch 03/19)
> 
> 
> Anyway, your 2 patches are now in our tree (feat. for net-next) with
> Mat's RvB tag and without a typo (s/priviledged/privileged/) + a
> small
> fix for checkpatch related to how the commit are mentioned, nothing
> important:

Thank you for the adjustments, the feedback and applying!!


> New patches for t/upstream:
> - 3d542a6c45ea: mptcp: allow privileged operations from user
> namespaces
> - 11bdb1959854: mptcp: account memory allocation in
> mptcp_nl_cmd_add_addr() to user
> - Results: c4a0ae952875..004104cc8a77 (export)
> 
> 
> Tests are now in progress:
> 
> https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220811T101116
> 
> 
> @Thomas: BTW, thank you for maintaining libnl!
> Funny that you sent these patches to MPTCP while earlier this week I
> sent the latest libnl version to Debian :)
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016867
> https://tracker.debian.org/pkg/libnl3

Oh, that's nice. After I rather neglected libnl for quite some time, I
want do to a better job in the future. :)



On an unrelated note: upcoming NetworkManager 1.40.0 release will have
basic MPTCP support and configure endpoints. Similar to what mptcpd
does. This was the backstory for the patches.



best,
Thomas