Re: [PATCH mptcp-net v2] mptcp: fix lockdep false positive

[Matthieu Baerts <matthieu.baerts@tessares.net>]

Hi Paolo, Mat,

On 14/12/2022 16:44, Paolo Abeni wrote:
> MatB reported a lockdep splat in the mptcp listener code cleanup:

(...)

> The report is actually a false positive, since the only existing lock
> nesting is the msk socket lock acquired by the mptcp work.
> cancel_work_sync() is invoked without the relevant socket lock being
> held, but under a different (the msk listener) socket lock.
> 
> We could silence the splat adding a per workqueue dynamic lockdep key,
> but that looks overkill. Instead just tell lockdep the msk socket lock
> is not held around cancel_work_sync().

Thank you for the patches, the great explanations and the reviews!

Now in our tree (fix for -net) with Mat's RvB, a Closes and RpB tags.

New patches for t/upstream-net and t/upstream:
- 71fd5e75df68: mptcp: fix lockdep false positive
- Results: d330d6da95d3..74c46cd6bf02 (export-net)
- Results: d3d3b2053b5b..130b6676200e (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20221215T095520
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20221215T095520

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net