From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [RESEND PATCH mptcp-next] selftests: mptcp: join: simplify checksum_tests
Date: Mon, 29 Jul 2024 12:21:47 +0200 [thread overview]
Message-ID: <cf0a5d7e-5bc0-453f-9ad3-42fc67fa768f@kernel.org> (raw)
In-Reply-To: <b61be1bd6c70121fee3c6e183fb224b41d9dac90.1722138514.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 28/07/2024 05:49, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> The four checksum tests are similar, only one line is different. So
> a for-loop can be used to simplify these tests.
I usually prefer distinct tests, if we want to extend them, or easily
check something else, but these checksum tests are a bit particular.
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-07-29 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-28 3:49 [RESEND PATCH mptcp-next] selftests: mptcp: join: simplify checksum_tests Geliang Tang
2024-07-28 4:40 ` MPTCP CI
2024-07-29 10:21 ` Matthieu Baerts [this message]
2024-07-29 10:44 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf0a5d7e-5bc0-453f-9ad3-42fc67fa768f@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox