MPTCP Linux Development
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: mptcp@lists.linux.dev
Cc: Geliang Tang <geliangtang@gmail.com>
Subject: [PATCH v4 mptcp-next 00/22] mptcp: data checksum support
Date: Fri, 23 Apr 2021 16:49:39 +0200	[thread overview]
Message-ID: <cover.1619189145.git.pabeni@redhat.com> (raw)

Changes from v3:
 - included Geliang's feedback
 - hopefully fixed wrong csum computation in the rx path
   for DSS+data_fin 

Changes from v2:
 - implement RFC behavior WRT csum failure and csum mismatch
 - cope with zero win probe and re-injection
 - fix csum computation for DSS with data_fin flag set

Only some Squash-to patches has been changes WRT the previous
iteration.

There is still at least a ough edge:
- the csum computation in the tx path is very suboptimal.

Anyhow, I propose to address the above with additional squash-to patches
to avoid complex/extra long review cycles.

Geliang Tang (14):
  mptcp: add csum_enabled in mptcp_sock
  mptcp: generate the data checksum
  mptcp: add csum_reqd in mptcp_out_options
  mptcp: send out checksum for MP_CAPABLE with data
  mptcp: send out checksum for DSS
  mptcp: add sk parameter for mptcp_parse_option
  mptcp: add csum_reqd in mptcp_options_received
  mptcp: receive checksum for MP_CAPABLE with data
  mptcp: receive checksum for DSS
  mptcp: validate the data checksum
  mptcp: add the mib for data checksum
  mptcp: add a new sysctl checksum_enabled
  selftests: mptcp: enable checksum in mptcp_connect.sh
  selftests: mptcp: enable checksum in mptcp_join.sh

Paolo Abeni (8):
  Squash-to: "mptcp: generate the data checksum"
  Squash-to: "mptcp: send out checksum for MP_CAPABLE with data"
  Squash-to "mptcp: send out checksum for DSS"
  Squash-to: "mptcp: receive checksum for MP_CAPABLE with data"
  Squash-to: "mptcp: receive checksum for DSS"
  Squash-to: mptcp: validate the data checksum
  mptcp: cleanup error path in subflow_check_data_avail()
  mptcp: tune re-injections for csum enabled mode.

 Documentation/networking/mptcp-sysctl.rst     |   8 +
 include/net/mptcp.h                           |   7 +-
 include/uapi/linux/mptcp.h                    |   1 +
 net/mptcp/ctrl.c                              |  14 ++
 net/mptcp/mib.c                               |   1 +
 net/mptcp/mib.h                               |   1 +
 net/mptcp/mptcp_diag.c                        |   1 +
 net/mptcp/options.c                           | 142 +++++++++++++-----
 net/mptcp/protocol.c                          |  39 ++++-
 net/mptcp/protocol.h                          |  23 ++-
 net/mptcp/subflow.c                           | 142 +++++++++++++++---
 .../selftests/net/mptcp/mptcp_connect.sh      |  13 +-
 .../testing/selftests/net/mptcp/mptcp_join.sh | 107 ++++++++++++-
 13 files changed, 423 insertions(+), 76 deletions(-)

-- 
2.26.2


             reply	other threads:[~2021-04-23 14:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 14:49 Paolo Abeni [this message]
2021-04-23 14:49 ` [PATCH v4 mptcp-next 01/22] mptcp: add csum_enabled in mptcp_sock Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 02/22] mptcp: generate the data checksum Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 03/22] Squash-to: "mptcp: generate the data checksum" Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 04/22] mptcp: add csum_reqd in mptcp_out_options Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 05/22] mptcp: send out checksum for MP_CAPABLE with data Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 06/22] Squash-to: "mptcp: send out checksum for MP_CAPABLE with data" Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 07/22] mptcp: send out checksum for DSS Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 08/22] Squash-to "mptcp: send out checksum for DSS" Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 09/22] mptcp: add sk parameter for mptcp_parse_option Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 10/22] mptcp: add csum_reqd in mptcp_options_received Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 11/22] mptcp: receive checksum for MP_CAPABLE with data Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 12/22] Squash-to: "mptcp: receive checksum for MP_CAPABLE with data" Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 13/22] mptcp: receive checksum for DSS Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 14/22] Squash-to: "mptcp: receive checksum for DSS" Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 15/22] mptcp: validate the data checksum Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 16/22] Squash-to: " Paolo Abeni
2021-04-23 23:42   ` Mat Martineau
     [not found]     ` <CAF6piCJ5Dv+5_LN-yaz0kdY_EM6LtyM7JmHY43ie+cFE_nf-=A@mail.gmail.com>
     [not found]       ` <24c5410-3b1-5efe-57b6-e1ab374ca52a@linux.intel.com>
2021-05-04  8:09         ` Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 17/22] mptcp: cleanup error path in subflow_check_data_avail() Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 18/22] mptcp: tune re-injections for csum enabled mode Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 19/22] mptcp: add the mib for data checksum Paolo Abeni
2021-04-23 14:49 ` [PATCH v4 mptcp-next 20/22] mptcp: add a new sysctl checksum_enabled Paolo Abeni
2021-04-23 14:50 ` [PATCH v4 mptcp-next 21/22] selftests: mptcp: enable checksum in mptcp_connect.sh Paolo Abeni
2021-04-23 14:50 ` [PATCH v4 mptcp-next 22/22] selftests: mptcp: enable checksum in mptcp_join.sh Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1619189145.git.pabeni@redhat.com \
    --to=pabeni@redhat.com \
    --cc=geliangtang@gmail.com \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox