MPTCP Linux Development
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: mptcp@lists.linux.dev
Cc: Phil Greenland <phil@quantulum.co.uk>
Subject: [PATCH mptcp-next v2 0/4] mptcp: improve subflow creation on errors
Date: Wed, 24 Nov 2021 17:22:10 +0100	[thread overview]
Message-ID: <cover.1637770883.git.pabeni@redhat.com> (raw)

Currently when a subflow connection fails - either the TCP
connection is reset by the peer, or the MPJ handshake never
completes - the in kernel PM don't perform any further action.
Notably no additional subflow creation is attempted.

This series is aimed at improving the in-kernel path manager
behavior in the above scenario:
- each endpoint is used only once per connection (patch 2/4)
- on failure we try to move to the next subflow, if any
  (patch 3/4)

The first patch is minor cleanup, and the last patch adds
specific self-tests.

This should address/close:
https://github.com/multipath-tcp/mptcp_net-next/issues/235
https://github.com/multipath-tcp/mptcp_net-next/issues/242

@Phil: could you please have a spin in your testbed? this
should really cover your use case for good - modulo bugs

Paolo Abeni (4):
  mptcp: clean-up MPJ option writing.
  mptcp: keep track of used local endpoint
  mptcp: do not block subflows creation on errors
  selftests: mptcp: add tests for subflow creation failure

 net/mptcp/options.c                           | 65 ++++++++++++-------
 net/mptcp/pm.c                                | 29 +++++++++
 net/mptcp/pm_netlink.c                        |  8 ++-
 net/mptcp/protocol.c                          |  6 ++
 net/mptcp/protocol.h                          |  5 +-
 net/mptcp/subflow.c                           |  5 +-
 tools/testing/selftests/net/mptcp/config      |  1 +
 .../testing/selftests/net/mptcp/mptcp_join.sh | 65 ++++++++++++++++++-
 8 files changed, 156 insertions(+), 28 deletions(-)

-- 
2.33.1


             reply	other threads:[~2021-11-24 16:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 16:22 Paolo Abeni [this message]
2021-11-24 16:22 ` [PATCH mptcp-next v2 1/4] mptcp: clean-up MPJ option writing Paolo Abeni
2021-11-24 16:22 ` [PATCH mptcp-next v2 2/4] mptcp: keep track of used local endpoint Paolo Abeni
2021-11-24 16:22 ` [PATCH mptcp-next v2 3/4] mptcp: do not block subflows creation on errors Paolo Abeni
2021-11-24 22:52   ` kernel test robot
2021-11-25  8:28     ` Paolo Abeni
2021-11-25  2:25   ` kernel test robot
2021-11-24 16:22 ` [PATCH mptcp-next v2 4/4] selftests: mptcp: add tests for subflow creation failure Paolo Abeni
2021-11-24 20:21   ` selftests: mptcp: add tests for subflow creation failure: Build Failure MPTCP CI
2021-11-24 23:01   ` MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1637770883.git.pabeni@redhat.com \
    --to=pabeni@redhat.com \
    --cc=mptcp@lists.linux.dev \
    --cc=phil@quantulum.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox