MPTCP Linux Development
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: mptcp@lists.linux.dev
Subject: [PATCH v3 mptcp-next 0/3] mptcp: misc improvement
Date: Fri, 15 Sep 2023 16:19:05 +0200	[thread overview]
Message-ID: <cover.1694787366.git.pabeni@redhat.com> (raw)

This series is a follow-up the discussion ongoing here:

https://github.com/multipath-tcp/mptcp_net-next/issues/437

Daire reported several sub-optimal MPTCP behaviour on high-latency
links.

At least 3 different items stands off:

* notsent_lowat setting fooling the scheduler
* sub-optimal send buffer autotuning
* delayed acks being de-facto disabled due to subflow rcvlowat

This series is an initial attempt to address the first 2 points above.
I have a tentative patch for the 3rd, but it's nowhere near passing
the self-tests, so it will have to wait a bit.

v2 -> v3:
 - avoid ingremental updates, always recompute sum(ssk->sndbuf) to avoid
   drift on memory pressure/decrease
 - add some needed comments

v1 -> v2:
 - fixed compiler warning in patch 3/3 && more local testing

Paolo Abeni (3):
  mptcp: consolidate sockopt synchronization
  mptcp: ignore notsent_lowat setting at the subflow level.
  mptcp: refactor sndbuf auto-tuning.

 net/mptcp/protocol.c | 21 +++++++++++++----
 net/mptcp/protocol.h | 54 ++++++++++++++++++++++++++++++++++++++++----
 net/mptcp/sockopt.c  | 28 +++++------------------
 net/mptcp/subflow.c  | 21 ++++++++---------
 4 files changed, 82 insertions(+), 42 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-09-15 14:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15 14:19 Paolo Abeni [this message]
2023-09-15 14:19 ` [PATCH v3 mptcp-next 1/3] mptcp: consolidate sockopt synchronization Paolo Abeni
2023-09-15 14:19 ` [PATCH v3 mptcp-next 2/3] mptcp: ignore notsent_lowat setting at the subflow level Paolo Abeni
2023-09-15 14:19 ` [PATCH v3 mptcp-next 3/3] mptcp: refactor sndbuf auto-tuning Paolo Abeni
2023-09-15 16:25   ` mptcp: refactor sndbuf auto-tuning.: Tests Results MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1694787366.git.pabeni@redhat.com \
    --to=pabeni@redhat.com \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox