From: Paolo Abeni <pabeni@redhat.com>
To: mptcp@lists.linux.dev
Cc: Christoph Paasch <cpaasch@apple.com>
Subject: [PATCH mptcp-next v4 0/4] mptcp: misc improvement
Date: Wed, 20 Sep 2023 11:09:08 +0200 [thread overview]
Message-ID: <cover.1695200723.git.pabeni@redhat.com> (raw)
This series is a follow-up the discussion ongoing here:
https://github.com/multipath-tcp/mptcp_net-next/issues/437
Daire reported several sub-optimal MPTCP behaviour on high-latency
links.
At least 3 different items stands off:
* notsent_lowat setting fooling the scheduler
* sub-optimal send buffer autotuning
* delayed acks being de-facto disabled due to subflow rcvlowat
This series is an attempt to address the first 2 points above.
v3 -> v4:
- added patch 1/4, fixing a pre-existing issue related. That patch
shoud likely go via -net, included here because the issue can not
manifest itself until patch 4/4.
Despite by best attempt to test this, I thing it would be easier
to just lest syzkaller crunch it more than a bit.
v2 -> v3:
- avoid ingremental updates, always recompute sum(ssk->sndbuf) to avoid
drift on memory pressure/decrease
- add some needed comments
v1 -> v2:
- fixed compiler warning in patch 3/3 && more local testing
Paolo Abeni (4):
mptcp: fix delegated action races.
mptcp: consolidate sockopt synchronization
mptcp: ignore notsent_lowat setting at the subflow level.
mptcp: refactor sndbuf auto-tuning.
net/mptcp/protocol.c | 48 +++++++++++++++---------
net/mptcp/protocol.h | 89 ++++++++++++++++++++++++++++++--------------
net/mptcp/sockopt.c | 28 +++-----------
net/mptcp/subflow.c | 27 +++++++-------
4 files changed, 111 insertions(+), 81 deletions(-)
--
2.41.0
next reply other threads:[~2023-09-20 9:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 9:09 Paolo Abeni [this message]
2023-09-20 9:09 ` [PATCH mptcp-next v4 1/4] mptcp: fix delegated action races Paolo Abeni
2023-09-20 19:46 ` Paolo Abeni
2023-09-21 23:42 ` Mat Martineau
2023-09-22 6:41 ` Paolo Abeni
2023-09-20 9:09 ` [PATCH mptcp-next v4 2/4] mptcp: consolidate sockopt synchronization Paolo Abeni
2023-09-20 9:09 ` [PATCH mptcp-next v4 3/4] mptcp: ignore notsent_lowat setting at the subflow level Paolo Abeni
2023-09-20 9:09 ` [PATCH mptcp-next v4 4/4] mptcp: refactor sndbuf auto-tuning Paolo Abeni
2023-09-20 10:14 ` mptcp: refactor sndbuf auto-tuning.: Tests Results MPTCP CI
2023-09-21 23:55 ` [PATCH mptcp-next v4 4/4] mptcp: refactor sndbuf auto-tuning Mat Martineau
2023-09-22 6:34 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1695200723.git.pabeni@redhat.com \
--to=pabeni@redhat.com \
--cc=cpaasch@apple.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox