From: Paolo Abeni <pabeni@redhat.com>
To: mptcp@lists.linux.dev
Subject: [PATCH mptcp-net v2 0/4] mptcp: fix duplicate subflow creation
Date: Thu, 8 Feb 2024 21:42:44 +0100 [thread overview]
Message-ID: <cover.1707418323.git.pabeni@redhat.com> (raw)
As reported by Mat, the in kernel PM can, in some edge scenarios,
unexpectedly create multiple subflows with the same local and remote
address.
The real fix is implemented by patch 4/4 with some more accurate check
at subflow creation time.
Patches 1-3 are roughly optional pre-requisities, added to avoid
introducing more data-races with the actual fix. Patch 1/4 is a bit
debatable, as it changes the existing ULP API, but I could not find a
better solution and there is some similar prior art:
commit 0df48c26d841 ("tcp: add tcpi_bytes_acked to tcp_info")
This address feedback from Mat on v1, see the patches changelog for
the details (no changes in patch 1/4).
Paolo Abeni (4):
mptcp: fix lockless access in subflow ULP diag
mptcp: fix data races on local_id
mptcp: fix data races on remote_id
mptcp: fix duplicate subflow creation
include/net/tcp.h | 2 +-
net/mptcp/diag.c | 8 +++++--
net/mptcp/pm_netlink.c | 45 +++++++++++++++++++++-------------------
net/mptcp/pm_userspace.c | 2 +-
net/mptcp/protocol.c | 2 +-
net/mptcp/protocol.h | 15 +++++++++++---
net/mptcp/subflow.c | 15 +++++++-------
net/tls/tls_main.c | 2 +-
8 files changed, 54 insertions(+), 37 deletions(-)
--
2.43.0
next reply other threads:[~2024-02-08 20:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 20:42 Paolo Abeni [this message]
2024-02-08 20:42 ` [PATCH mptcp-net v2 1/4] mptcp: fix lockless access in subflow ULP diag Paolo Abeni
2024-02-08 20:42 ` [PATCH mptcp-net v2 2/4] mptcp: fix data races on local_id Paolo Abeni
2024-02-08 20:42 ` [PATCH mptcp-net v2 3/4] mptcp: fix data races on remote_id Paolo Abeni
2024-02-08 20:42 ` [PATCH mptcp-net v2 4/4] mptcp: fix duplicate subflow creation Paolo Abeni
2024-02-08 21:34 ` mptcp: fix duplicate subflow creation: Tests Results MPTCP CI
2024-02-08 21:57 ` MPTCP CI
2024-02-09 1:17 ` MPTCP CI
2024-02-09 1:54 ` MPTCP CI
2024-02-09 0:23 ` [PATCH mptcp-net v2 0/4] mptcp: fix duplicate subflow creation Mat Martineau
2024-02-09 14:20 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1707418323.git.pabeni@redhat.com \
--to=pabeni@redhat.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox