From: Geliang Tang <geliang@kernel.org>
To: mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: [PATCH mptcp-next v2 0/3] fixes for "add mptcp_subflow bpf_iter" v10
Date: Thu, 17 Oct 2024 18:55:29 +0800 [thread overview]
Message-ID: <cover.1729162349.git.tanggeliang@kylinos.cn> (raw)
From: Geliang Tang <tanggeliang@kylinos.cn>
v2:
- drop unused variable 'err'.
There are two building errors in v10:
progs/mptcp_bpf_iters.c:24:8: error: call to undeclared function 'bpf_mptcp_sk'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
24 | msk = bpf_mptcp_sk((struct sock *)sk);
| ^
progs/mptcp_bpf_iters.c:24:6: error: incompatible integer to pointer conversion assigning to 'struct mptcp_sock *' from 'int' [-Wint-conversion]
24 | msk = bpf_mptcp_sk((struct sock *)sk);
tools/testing/selftests/bpf/prog_tests/mptcp.c: In function 'test_iters_subflow':
tools/testing/selftests/bpf/prog_tests/mptcp.c:546:13: error: unused variable 'err' [-Werror=unused-variable]
546 | int err;
| ^~~
TEST-OBJ [test_progs] pe_preserve_elems.test.o
bpf_mptcp_sk() definition is missing. It will be used in patch 4.
An unused variable 'err' needs to be dropped.
Depends on:
- "add mptcp_subflow bpf_iter" v10
Based-on: <cover.1729063444.git.tanggeliang@kylinos.cn>
Geliang Tang (3):
Squash to "bpf: Register mptcp common kfunc set"
Squash to "selftests/bpf: Add mptcp_subflow bpf_iter test prog"
Squash to "selftests/bpf: Add mptcp_subflow bpf_iter subtest"
net/mptcp/bpf.c | 6 ++++++
tools/testing/selftests/bpf/prog_tests/mptcp.c | 1 -
tools/testing/selftests/bpf/progs/mptcp_bpf.h | 1 +
3 files changed, 7 insertions(+), 1 deletion(-)
--
2.43.0
next reply other threads:[~2024-10-17 10:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 10:55 Geliang Tang [this message]
2024-10-17 10:55 ` [PATCH mptcp-next v2 1/3] Squash to "bpf: Register mptcp common kfunc set" Geliang Tang
2024-10-17 10:55 ` [PATCH mptcp-next v2 2/3] Squash to "selftests/bpf: Add mptcp_subflow bpf_iter test prog" Geliang Tang
2024-10-17 10:55 ` [PATCH mptcp-next v2 3/3] Squash to "selftests/bpf: Add mptcp_subflow bpf_iter subtest" Geliang Tang
2024-10-17 12:09 ` [PATCH mptcp-next v2 0/3] fixes for "add mptcp_subflow bpf_iter" v10 MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1729162349.git.tanggeliang@kylinos.cn \
--to=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox