MPTCP Linux Development
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: mptcp@lists.linux.dev
Cc: yangang@kylinos.cn, geliang@kernel.org, matttbe@kernel.org
Subject: [PATCH mptcp-next v1 0/9] mptcp: address stall under memory pressure
Date: Fri, 24 Apr 2026 16:08:33 +0200	[thread overview]
Message-ID: <cover.1777038888.git.pabeni@redhat.com> (raw)

This an attempt to fix the data transfer stall reported by Geliang and
Gang more carefully enforcing memory constraints at the MPTCP level.

Patch 1/9 moves the bound check before entering the TCP socket.
Patch 2, 3 and 4 are cleanups/refactors finalized to safely re-using TCP
helpers on MPTCP skbs.
Patch 5 makes TCP pruning related helpers available to MPTCP and patch 6
makes use of them. Patch 7 addresses an edge scenario that could still
lead to transfer stall under memory pressure.
Finally patch 8 and 9 improve the MPTCP-level retransmission schema to
make recovery from memory pressure significanly faster.

Note that the diffstat is biases by the quite large patch 4/9, which
contains mechanical transformation of existing code; "real" changes are
noticiable smaller.

Tested successfully vs the test cases proposed by Geliang and Gang.
---
RFC -> v1:
 - dropped old patch 4 & 5
 - addressed AI reported comments
 - added retrans refactor.

Paolo Abeni (9):
  mptcp: move checks vs rcvbuf size earlier in the RX path
  mptcp: drop the mptcp_ooo_try_coalesce() helper
  mptcp: remove CB offset field
  mptcp: sync mptcp skb cb layout with tcp one
  tcp: expose the tcp_collapse_ofo_queue() helper to mptcp usage, too
  mptcp: implemented OoO queue pruning
  mptcp: track prune recovery status
  mptcp: move the retrans loop to a separate helper
  mptcp: let the retrans scheduler do its job.

 include/net/tcp.h    |   8 ++
 net/ipv4/tcp_input.c |  55 +++++---
 net/mptcp/fastopen.c |   1 -
 net/mptcp/mib.c      |   3 +
 net/mptcp/mib.h      |   3 +
 net/mptcp/options.c  |  55 +++++++-
 net/mptcp/protocol.c | 328 ++++++++++++++++++++++++++++---------------
 net/mptcp/protocol.h |  11 +-
 net/mptcp/subflow.c  |   2 +
 9 files changed, 323 insertions(+), 143 deletions(-)

-- 
2.53.0


             reply	other threads:[~2026-04-24 14:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24 14:08 Paolo Abeni [this message]
2026-04-24 14:08 ` [PATCH mptcp-next v1 1/9] mptcp: move checks vs rcvbuf size earlier in the RX path Paolo Abeni
2026-04-24 14:08 ` [PATCH mptcp-next v1 2/9] mptcp: drop the mptcp_ooo_try_coalesce() helper Paolo Abeni
2026-04-24 14:08 ` [PATCH mptcp-next v1 3/9] mptcp: remove CB offset field Paolo Abeni
2026-04-24 14:08 ` [PATCH mptcp-next v1 4/9] mptcp: sync mptcp skb cb layout with tcp one Paolo Abeni
2026-04-24 14:08 ` [PATCH mptcp-next v1 5/9] tcp: expose the tcp_collapse_ofo_queue() helper to mptcp usage, too Paolo Abeni
2026-04-24 14:08 ` [PATCH mptcp-next v1 6/9] mptcp: implemented OoO queue pruning Paolo Abeni
2026-04-24 14:08 ` [PATCH mptcp-next v1 7/9] mptcp: track prune recovery status Paolo Abeni
2026-04-24 14:08 ` [PATCH mptcp-next v1 8/9] mptcp: move the retrans loop to a separate helper Paolo Abeni
2026-04-24 14:08 ` [PATCH mptcp-next v1 9/9] mptcp: let the retrans scheduler do its job Paolo Abeni
2026-04-24 16:29 ` [PATCH mptcp-next v1 0/9] mptcp: address stall under memory pressure MPTCP CI
2026-04-27  7:27 ` Geliang Tang
2026-04-28  8:16   ` Geliang Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1777038888.git.pabeni@redhat.com \
    --to=pabeni@redhat.com \
    --cc=geliang@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=yangang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox