MPTCP Linux Development
 help / color / mirror / Atom feed
From: Gang Yan <gang.yan@linux.dev>
To: mptcp@lists.linux.dev
Subject: [PATCH mptcp-next v7 0/6] mptcp: avoid data-races around the sysctls
Date: Wed, 23 Sep 2026 17:49:13 +0800	[thread overview]
Message-ID: <cover.1790147728.git.yangang@kylinos.cn> (raw)

From: Gang Yan <yangang@kylinos.cn>

Changlog:
v7:
Patch 5:
 - Rephrase the commit message accoding to sashiko's comments.[1]

Patch 6:
 - Fix the use-after-free reported by sashiko [2]: the module reference is
   now taken inside the same RCU read section as the pointer fetch in
   mptcp_pm_data_reset(), so the ops cannot be freed between the
   rcu_read_unlock() and the bpf_try_module_get() that previously
   lived in mptcp_pm_ops_init(). The fallback to mptcp_pm_kernel now
   takes a reference as well, fixing a pre-existing refcount
   underflow when MPTCP is built as a module.
 - Fix the reported use-after-free in [2]: take the module reference inside
   the same RCU read section as the pointer fetch.
 - The remaining of [2] are not actual issues, along with the
   "scheduling while atomic" one which does not apply: lock_sock()
   has mutex semantics, no spinlock is held across synchronize_rcu().
 - Clear the pm.ops inherited by cloned sockets before re-selecting
   it: the clone entered the swap logic with a reference it never
   took, and the grace period wait could run in RX softirq.
 - Wait for a grace period before releasing the retired ops in all
   cases (same-ops reuse and final destruction included).
v6:
 Link: https://patchwork.kernel.org/project/mptcp/cover/20260904093531.20023-1-gang.yan@linux.dev/
v5:
 Link: https://patchwork.kernel.org/project/mptcp/cover/20260828060643.14397-1-gang.yan@linux.dev/

v4:
 Link: https://patchwork.kernel.org/project/mptcp/cover/20260824073625.57471-1-gang.yan@linux.dev/

v3:
 Link: https://patchwork.kernel.org/project/mptcp/cover/20260819125629.49823-1-gang.yan@linux.dev/

v2:
 Link: https://patchwork.kernel.org/project/mptcp/cover/20260818094825.48446-1-gang.yan@linux.dev/

v2:
 Link: https://patchwork.kernel.org/project/mptcp/cover/20260817012452.7519-1-gang.yan@linux.dev/

[1] https://sashiko.dev/#/patchset/20260904093531.20023-1-gang.yan@linux.dev?part=5
[2] https://sashiko.dev/#/patchset/20260904093531.20023-1-gang.yan@linux.dev?part=6

Gang Yan (5):
  mptcp: sched: change scheduler sysctl atomically
  mptcp: pm: change path_manager sysctl atomically
  mptcp: pm: use WRITE_ONCE() for the pm_type sysctl
  Squash-to "mptcp: pm: init and release mptcp_pm_ops"
  Squash to previous one

Matthieu Baerts (NGI0) (1):
  mptcp: use READ_ONCE() over sysctls

 net/mptcp/ctrl.c     | 141 ++++++++++++++++++++++++++++++++-----------
 net/mptcp/pm.c       |  64 ++++++++++++++------
 net/mptcp/protocol.c |   7 ++-
 net/mptcp/protocol.h |   9 +--
 net/mptcp/sched.c    |   2 +-
 net/mptcp/subflow.c  |   9 ++-
 6 files changed, 171 insertions(+), 61 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-09-23  9:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23  9:49 Gang Yan [this message]
2026-09-23  9:49 ` [PATCH mptcp-next v7 1/6] mptcp: sched: change scheduler sysctl atomically Gang Yan
2026-09-23  9:49 ` [PATCH mptcp-next v7 2/6] mptcp: pm: change path_manager " Gang Yan
2026-09-23  9:49 ` [PATCH mptcp-next v7 3/6] mptcp: use READ_ONCE() over sysctls Gang Yan
2026-09-23  9:49 ` [PATCH mptcp-next v7 4/6] mptcp: pm: use WRITE_ONCE() for the pm_type sysctl Gang Yan
2026-09-23  9:49 ` [PATCH mptcp-next v7 5/6] Squash-to "mptcp: pm: init and release mptcp_pm_ops" Gang Yan
2026-09-23  9:49 ` [PATCH mptcp-next v7 6/6] Squash to previous one Gang Yan
2026-09-23 10:11   ` sashiko-bot
2026-09-24  1:53     ` gang.yan
2026-09-23 10:52 ` [PATCH mptcp-next v7 0/6] mptcp: avoid data-races around the sysctls MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1790147728.git.yangang@kylinos.cn \
    --to=gang.yan@linux.dev \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox