Re: [PATCH mptcp-net] selftests: mptcp: join: fix local endp not being tracked

[Matthieu Baerts <matttbe@kernel.org>]

Hi Mat,

On 14/01/2026 17:50, Mat Martineau wrote:
> On Mon, 22 Dec 2025, Matthieu Baerts (NGI0) wrote:
> 
>> When running this mptcp_join.sh selftest on older kernel versions not
>> supporting local endpoints tracking, this test fails because 3 MP_JOIN
>> ACKs have been received, while only 2 were expected.
>>
>> It is not clear why only 2 MP_JOIN ACKs were expected on old kernel
>> versions, while 3 MP_JOIN SYN and SYN+ACK were expected. When testing on
>> the v5.15.197 kernel, 3 MP_JOIN ACKs are seen, which is also what is
>> expected in the selftests included in this kernel version, see commit
>> f4480eaad489 ("selftests: mptcp: add missing join check").
>>
>> Switch the expected MP_JOIN ACKs to 3. While at it, move this
>> chk_join_nr helper out of the special condition for older kernel
>> versions as it is now the same as with more recent ones. Also, invert
>> the condition to be more logical: what's expected on newer kernel
>> versions having such helper first.
>>
>> Fixes: d4c81bbb8600 ("selftests: mptcp: join: support local endpoint
>> being tracked or not")
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> Looks good to me, thanks Matthieu.
> 
> Reviewed-by: Mat Martineau <martineau@kernel.org>

Thank you for the review!

Now in our tree:

New patches for t/upstream-net and t/upstream:
- b799002f1f8e: selftests: mptcp: join: fix local endp not being tracked
- Results: fb96b304d88a..af4181f61c9c (export-net)
- Results: ba44c0dbd2e9..b8bb952910af (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/7ad24eb2a484fcd7d6e9d6d8d3285c917abc6354/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/fce2d92251d9288da07c20f381ec436d24b0e2ee/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.