Re: [PATCH v3 mptcp-next 0/3] mptcp: minor out optimization

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Mon, 26 Jul 2021, Paolo Abeni wrote:

> This series implements a few ideas discussed in the past mtg,
> specifcally:
>
> https://github.com/multipath-tcp/mptcp_net-next/issues/15
> https://github.com/multipath-tcp/mptcp_net-next/issues/42
>
> The final goal is shrink the mptcp_out_options struct, which is
> always zeroed by the plain TCP protocol in the output path.
>
> This iteration covers the feedback provided by Geliang (many thanks!)
> on v1:
> - some code moved to new squash-to patch 1/3
> - some cleanup in 2/3
>
> please see the individual patch changelog for the details
>
> Paolo Abeni (3):
>  Squash-to: "mptcp: move drop_other_suboptions check under pm lock"
>  mptcp: optimize out option generation
>  mptcp: shrink mptcp_out_options struct
>
> include/net/mptcp.h  |  26 +++--
> net/mptcp/options.c  | 227 +++++++++++++++++++++++--------------------
> net/mptcp/pm.c       |   9 +-
> net/mptcp/protocol.h |   1 +
> 4 files changed, 142 insertions(+), 121 deletions(-)
>
> -- 
> 2.26.3

Hi Paolo -

This refactoring looks good to me, and the tests pass on my system. Thanks 
for shrinking mptcp_out_options!

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

--
Mat Martineau
Intel