From: Matthieu Baerts <matttbe@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>,
Ankit Khushwaha <ankitkhushwaha.linux@gmail.com>
Cc: Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] selftests: mptcp: Mark xerror __noreturn
Date: Sun, 30 Nov 2025 18:09:18 +0100 [thread overview]
Message-ID: <d4656eca-3c65-407b-a487-0a1816c38036@kernel.org> (raw)
In-Reply-To: <20251129174133.0e369f80@kernel.org>
Hi Jakub, Ankit,
On 30/11/2025 02:41, Jakub Kicinski wrote:
> On Sat, 29 Nov 2025 19:13:08 +0100 Matthieu Baerts wrote:
>>> +$(OUTPUT)/mptcp_connect: CFLAGS += -I$(top_srcdir)/tools/include
>>> +$(OUTPUT)/mptcp_sockopt: CFLAGS += -I$(top_srcdir)/tools/include
>>> +$(OUTPUT)/mptcp_inq: CFLAGS += -I$(top_srcdir)/tools/include
>
> I believe this is being added via MM or kselftest tree at level of the
> main ksft makefile. Since this is a false positive, maybe let's defer
> fixing the issue until after the merge window? When the -I.. flag
> will be implicitly in place?
@Jakub: Thank you for sharing this, I didn't know about that. That makes
sense to wait.
@Ankit: do you mind sending a v3 without the modifications of the
Makefile, and supporting die_perror() in a bit more than 2 weeks or
later, please?
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-11-30 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 4:38 [PATCH net-next v2] selftests: mptcp: Mark xerror __noreturn Ankit Khushwaha
2025-11-29 6:07 ` MPTCP CI
2025-11-29 18:13 ` Matthieu Baerts
2025-11-30 1:41 ` Jakub Kicinski
2025-11-30 17:09 ` Matthieu Baerts [this message]
2025-12-01 4:07 ` Ankit Khushwaha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4656eca-3c65-407b-a487-0a1816c38036@kernel.org \
--to=matttbe@kernel.org \
--cc=ankitkhushwaha.linux@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox