From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next] selftests: mptcp: diag: drop nlh parameter of recv_nlmsg
Date: Thu, 10 Apr 2025 19:39:41 +0200 [thread overview]
Message-ID: <d62684de-e27b-482d-b688-46e387ac305e@kernel.org> (raw)
In-Reply-To: <0a7cb982ea5886c2f00e69703feb92c3934dcd63.1744012385.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 07/04/2025 09:53, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> It's strange that 'nlh' variable is set to NULL in get_mptcpinfo() and then
> this NULL pointer is passed to recv_nlmsg(). In fact, this variable should
> be defined in recv_nlmsg(), not get_mptcpinfo().
>
> So this patch drops this useless 'nlh' parameter of recv_nlmsg() and define
> 'nlh' variable in recv_nlmsg().
Indeed, that is better like that.
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-04-10 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 7:53 [PATCH mptcp-next] selftests: mptcp: diag: drop nlh parameter of recv_nlmsg Geliang Tang
2025-04-07 9:13 ` MPTCP CI
2025-04-10 17:39 ` Matthieu Baerts [this message]
2025-04-10 17:44 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d62684de-e27b-482d-b688-46e387ac305e@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox