Re: [RFC mptcp-next v5 6/8] selftests: mptcp: sockopt: implement MPTCP KTLS tests

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 22/12/2025 04:15, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> This patch adds Kernel TLS (KTLS) testing infrastructure to MPTCP sockopt
> selftest, introducing a new '-c' option to enable TLS tests. It includes
> a helper for configuring TLS socket options and implements MPTCP-specific
> KTLS test cases for both IPv4 and IPv6, along with the necessary header
> includes and config updates.
> 
> TLS_OVERHEAD_SIZE macro is defined to account for the overhead in sent
> and received data length.

When quickly looking at the code and the commit message, it is not clear
what this does: does it only set the TLS socket options, and that's it?
If yes, that's not enough, and it might give confusing results if the
new feature is not "properly" tested.

I think a "proper" test would involve transferring data with multiple
subflows (with data going through the different subflows and correctly
processed). That's more complex to put in place, but this looks required.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.