MPTCP Linux Development
 help / color / mirror / Atom feed
From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp 0/2] mptcp: a couple of fix - almost
Date: Fri, 20 Aug 2021 16:02:29 -0700 (PDT)	[thread overview]
Message-ID: <dcc47221-50b4-6c46-320-7231ba4a211f@linux.intel.com> (raw)
In-Reply-To: <cover.1629481305.git.pabeni@redhat.com>

On Fri, 20 Aug 2021, Paolo Abeni wrote:

> This are couple of changes poped-up while investigating
> issues/219. They does not address the mentioned issue,
> but the first one should fix an actual bug, the other
> is more a cleanup, so the target tree is undefined ;)
>
> Paolo Abeni (2):
>  mptcp: fix possible divide by zero
>  mptcp: make the locking tx schema more readable
>
> net/mptcp/protocol.c | 73 +++++++++++++++++++++-----------------------
> 1 file changed, 35 insertions(+), 38 deletions(-)
>
> -- 
> 2.26.3

So far my syzkaller setup hasn't seen the div-by-0 again, but it was 
typically taking days to show up. I'll leave that running over the 
weekend.

Changes look good to me - mptcp_push_release() is now only called from 
places where info->mss_now is non-zero.

Patch 1 for -net, patch 2 for net-next seems appropriate.

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

--
Mat Martineau
Intel

  parent reply	other threads:[~2021-08-20 23:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 17:44 [PATCH mptcp 0/2] mptcp: a couple of fix - almost Paolo Abeni
2021-08-20 17:44 ` [PATCH mptcp 1/2] mptcp: fix possible divide by zero Paolo Abeni
2021-08-20 17:53   ` Mat Martineau
2021-08-24  7:28   ` Matthieu Baerts
2021-08-20 17:44 ` [PATCH mptcp 2/2] mptcp: make the locking tx schema more readable Paolo Abeni
2021-08-20 23:02 ` Mat Martineau [this message]
2021-08-23  7:16   ` [PATCH mptcp 0/2] mptcp: a couple of fix - almost Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcc47221-50b4-6c46-320-7231ba4a211f@linux.intel.com \
    --to=mathew.j.martineau@linux.intel.com \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox