Re: [PATCH mptcp-next 3/7] mptcp: let the retrans scheduler do its job

[Paolo Abeni <pabeni@redhat.com>]

On 8/5/26 6:17 PM, Paolo Abeni wrote:
> @@ -2856,15 +2854,60 @@ static void __mptcp_retrans(struct sock *sk)
>  	struct mptcp_sock *msk = mptcp_sk(sk);
>  	struct mptcp_subflow_context *subflow;
>  	struct mptcp_data_frag *dfrag;
> +	u64 retrans_seq, sent_seq;
> +	bool need_retrans;
>  	int err, len;
>  
>  	mptcp_pm_chk_stale(msk);
>  
> -	mptcp_clean_una_wakeup(sk);
> +	for (;;) {
> +		/* Get an updated and consistent rtx queue status. */
> +		mptcp_data_lock(sk);
> +		__mptcp_clean_una_wakeup(sk);
> +		retrans_seq = msk->snd_una;
> +		dfrag = mptcp_rtx_head(sk);
> +		need_retrans = !!dfrag;
> +		mptcp_data_unlock(sk);

too much cleanup here. This needs more work

/P